XcodesOrg / xcodes

The best command-line tool to install and switch between multiple versions of Xcode.
MIT License
3.66k stars 122 forks source link

Question: About sudo process migration #224

Closed noppefoxwolf closed 1 year ago

noppefoxwolf commented 1 year ago

Hi, I'm interested in having PAM available in xcodes. I'll try to make a PR, but I have a few questions before it.

  1. Are there any concerns about using posix_spawn instead of Process when running sudo?
  2. Is it OK to obsolete readSecureLine?

I would like to do the migration without interfering with the current use case.

Thanks

noppefoxwolf commented 1 year ago

By becoming sudo via PAM, you can do without custom password input and use a user-specified method (ex. Touch ID).

MattKiazyk commented 1 year ago

Hi @noppefoxwolf always open for ways to make Xcodes better!

  1. From what I read and my understanding, there is no current concerns with using posix_spawn
  2. I'm not too familiar with PAM but Xcode CLI can be used in CI environments so as long as there are options to keep the existing functionality (manually type in sudo password security) i'm up to see how it can be improved.
noppefoxwolf commented 1 year ago

@MattKiazyk Thank you for feedback!

I'm not too familiar with PAM but Xcode CLI can be used in CI environments so as long as there are options to keep the existing functionality (manually type in sudo password security) i'm up to see how it can be improved.

OK, I wasn't thinking about CI. I'd like to keep the current behavior and provide the option to use PAM.