Xcone / factorio_pump

MIT License
1 stars 5 forks source link

Hotkey func #20

Closed iamtimsson closed 1 year ago

iamtimsson commented 1 year ago

Hey bud love your mod I want less carpal tunnels please have this and make my year

Xcone commented 1 year ago

Hi! Thanks for PR. I'll happily add key-binding directly into P.U.M.P.

I might need a bit of an explainer, though. It seems there's a lot more going on in this PR then is strictly needed to get a keybinding to work. I have the impression there's a lot of fluff since you published a copy of the mod as well which don't really need to find it's way back into P.U.M.P.

So which bit(s) is/are needed to get a keybinding to work? I identified:

Please let me know if there's another bit that's essential.

I also can't really accept the PR as a whole, since it'd just break something in my repo. So what would you prefer? I can make my own commit cherry picking things from this PR. But since I'd not apply the PR as offered I'm not sure Github will recognize it as such. If you have the change to offer a PR with just the essentials I can simply accept it, which would for sure include you into the contributors here, too. Or is there a way I can only accept small bits? Or manually add you as contributor? I'm not really familiar with the possibilities GitHub as it's not my primary tool in daily life :-)

Xcone commented 1 year ago

I ended up just accepting the PR, and making a revertion-commit for some of the changes. I hope GitHub will pick up on that. I also condensed your credits entry a little in the changelog. I hope you don't mind.

Version is uploaded to mod portal as well.

Thanks again for the PR.