Closed maplonki closed 3 years ago
@jumaallan @maplonki fastlane android test CI is breaking;
I noticed
Issue is the key.properties file
@maplonki - you can pass the config via Fastlane. Let me know if you can set that up
I noticed
Issue is the key.properties file
@maplonki - you can pass the config via Fastlane. Let me know if you can set that up
@jumaallan can you help out with that?
I noticed Issue is the key.properties file @maplonki - you can pass the config via Fastlane. Let me know if you can set that up
@jumaallan can you help out with that?
@jumaallan you can push this commit
any updates here?
any updates here?
Let me fix that today
any updates here?
Let me fix that today
@codecakes @maplonki
I've replaced the implementation that reads from keys.properties file, and replaced with one that reads from gradle.properties - this can be done in two ways:
I'll document on the README, how to do that.
I have also updated Fastlane to read the Maps API Key, from Github Secrets when doing a build - @codecakes - Kindly create a secret with the name MAPS_DEBUG_KEY, and paste the debug API Key - builds should now work with that
any updates here?
Let me fix that today
@codecakes @maplonki
I've replaced the implementation that reads from keys.properties file, and replaced with one that reads from gradle.properties - this can be done in two ways:
1. on the local gradle.properties 2. on the global gradle.properties
I'll document on the README, how to do that.
I have also updated Fastlane to read the Maps API Key, from Github Secrets when doing a build - @codecakes - Kindly create a secret with the name MAPS_DEBUG_KEY, and paste the debug API Key - builds should now work with that
Thanks @jumaallan ; could you ping me our group the api key?
any updates here?
Let me fix that today
@codecakes @maplonki I've replaced the implementation that reads from keys.properties file, and replaced with one that reads from gradle.properties - this can be done in two ways:
1. on the local gradle.properties 2. on the global gradle.properties
I'll document on the README, how to do that. I have also updated Fastlane to read the Maps API Key, from Github Secrets when doing a build - @codecakes - Kindly create a secret with the name MAPS_DEBUG_KEY, and paste the debug API Key - builds should now work with that
Thanks @jumaallan ; could you ping me our group the api key?
I don't have the API Key, probably @maplonki has the keys
@jumaallan is the linter used in the ide adding blank line EOF?
I don't think so - I will setup the following:
I'll do a separate PR for that
@jumaallan is the linter used in the ide adding blank line EOF?
I don't think so - I will setup the following:
1. https://github.com/JLLeitschuh/ktlint-gradle 2. https://github.com/detekt/detekt 3. https://github.com/diffplug/spotless
I'll do a separate PR for that
thanks alot!@
Added some TODOs, and dummy code to kill the linter warnings - FYI
@maplonki @codecakes
We need to merge all PRs to develop, and rework from there
@maplonki can you merge this? or @codecakes - I am not able to merge the PR
This adds the location request portion of the search and displays the user location on the map.
Will update once the backend portion is finished