Xcov19 / android-mycovidconnect

Android CovidConnect App src code
GNU Affero General Public License v3.0
1 stars 7 forks source link

Feat/myc 55 - Search functionality #19

Closed maplonki closed 3 years ago

maplonki commented 3 years ago

This adds the location request portion of the search and displays the user location on the map.

Will update once the backend portion is finished

codecakes commented 3 years ago

@jumaallan @maplonki fastlane android test CI is breaking;

jumaallan commented 3 years ago

I noticed

Issue is the key.properties file

@maplonki - you can pass the config via Fastlane. Let me know if you can set that up

maplonki commented 3 years ago

I noticed

Issue is the key.properties file

@maplonki - you can pass the config via Fastlane. Let me know if you can set that up

@jumaallan can you help out with that?

codecakes commented 3 years ago

I noticed Issue is the key.properties file @maplonki - you can pass the config via Fastlane. Let me know if you can set that up

@jumaallan can you help out with that?

@jumaallan you can push this commit

codecakes commented 3 years ago

any updates here?

jumaallan commented 3 years ago

any updates here?

Let me fix that today

jumaallan commented 3 years ago

any updates here?

Let me fix that today

@codecakes @maplonki

I've replaced the implementation that reads from keys.properties file, and replaced with one that reads from gradle.properties - this can be done in two ways:

  1. on the local gradle.properties
  2. on the global gradle.properties

I'll document on the README, how to do that.

I have also updated Fastlane to read the Maps API Key, from Github Secrets when doing a build - @codecakes - Kindly create a secret with the name MAPS_DEBUG_KEY, and paste the debug API Key - builds should now work with that

codecakes commented 3 years ago

any updates here?

Let me fix that today

@codecakes @maplonki

I've replaced the implementation that reads from keys.properties file, and replaced with one that reads from gradle.properties - this can be done in two ways:

1. on the local gradle.properties

2. on the global gradle.properties

I'll document on the README, how to do that.

I have also updated Fastlane to read the Maps API Key, from Github Secrets when doing a build - @codecakes - Kindly create a secret with the name MAPS_DEBUG_KEY, and paste the debug API Key - builds should now work with that

Thanks @jumaallan ; could you ping me our group the api key?

jumaallan commented 3 years ago

any updates here?

Let me fix that today

@codecakes @maplonki I've replaced the implementation that reads from keys.properties file, and replaced with one that reads from gradle.properties - this can be done in two ways:

1. on the local gradle.properties

2. on the global gradle.properties

I'll document on the README, how to do that. I have also updated Fastlane to read the Maps API Key, from Github Secrets when doing a build - @codecakes - Kindly create a secret with the name MAPS_DEBUG_KEY, and paste the debug API Key - builds should now work with that

Thanks @jumaallan ; could you ping me our group the api key?

I don't have the API Key, probably @maplonki has the keys

jumaallan commented 3 years ago

@jumaallan is the linter used in the ide adding blank line EOF?

I don't think so - I will setup the following:

  1. https://github.com/JLLeitschuh/ktlint-gradle
  2. https://github.com/detekt/detekt
  3. https://github.com/diffplug/spotless

I'll do a separate PR for that

codecakes commented 3 years ago

@jumaallan is the linter used in the ide adding blank line EOF?

I don't think so - I will setup the following:

1. https://github.com/JLLeitschuh/ktlint-gradle

2. https://github.com/detekt/detekt

3. https://github.com/diffplug/spotless

I'll do a separate PR for that

thanks alot!@

jumaallan commented 3 years ago

Added some TODOs, and dummy code to kill the linter warnings - FYI

@maplonki @codecakes

We need to merge all PRs to develop, and rework from there

jumaallan commented 3 years ago

image

@maplonki can you merge this? or @codecakes - I am not able to merge the PR