Open codecakes opened 1 month ago
@codecakes is this open and requier's issue #12 to be solved first ? , i would like to contribute to the issue , any deadlines or other info i need to know
42
@RISHIKESHk07 Short answer: No. All issues are independent. Go ahead with the PR.
Refer to PR #42 to understand what files you would be leveraging upon in order to do this. Ask for any doubts.
@codecakes did try running poetry install --no-root --with=dev
but got the error group dev not found , i see the line commented out
@codecakes do i install without --with=dev
flag
@codecakes did try running
poetry install --no-root --with=dev
but got the error group dev not found , i see the line commented out
@RISHIKESHk07 The setup has been simplified. See Contributing; Let me know if this worked for you.
Brownie point if you raise a PR that fixes this setup instruction in the README.md
. It should simply point to the CONTRIBUTING page.
Ticket Contents
Description
Issue #12 covers a high complexity objective to implement
/geo
api endpoint. In order to list facilities, implement a repository to be consumed from GeolocationQueryService.Background:
The project has 3 primary levels:
The project src directory contains the following:
The GeolocationQueryService is an application service consumed by the web api route
geo
. See here.The service needs to query the storage layer via a storage repository. This repository is called by the patient query look up service which is a callable and it calls the repository passing relevant parameters available in the set of:
[Address, LocationQueryJSON, List[FacilitiesResult]]
which are defined indto.py
.In the repository pattern, extend
IProviderStore
interface indomain/models/provider.py
and implement a provider store with implementation in sqlite to allow GeolocationQueryService to fetch healthcare providers in a storage -agnostic manner.See You Wanted Banana and API First design for motivation
Goals
Goals
Expected Outcome
Acceptance Criteria
repository.py
under apps/ moduleImplementation Details
The repository’s role is to handle the persistence of aggregates.
Refer to
dto.py
andprovider.py
in order to understand the flow as described here.The Repository receives aggregate as input parameters so first think and map the necessary DTOs to aggregate. The caller service transforms DTO to aggregates. The repository takes in and preprocesses
query_id
,cust_id
in addition to geo location coordinates in order to call sqlite db and return a list of records, the return schema for which is defined in #12 ; The repository takes in the aggregateProvider
inprovider.py
and performs a geo-query to filter all records that are within 50 kms of the patient's coordinates.Query against the following tentative table attributes from the repository:
Expected return value For each query_id and cust_id, filter down the coordinates lat and lng and return the data. Ignore the missing attributes from the attribute column that you cannot find. Let the missing return parameters be optional while maintaining strong consistency with the JSON Type format per attribute.
Mockups/Wireframes
Product Name
project-healthcare
Organisation Name
XCoV19
Domain
Healthcare
Tech Skills Needed
Database, Debugging, Flask, Python, SQL, Test, Testing Library
Mentor(s)
@codecakes
Complexity
High
Category
Backend, Database, Refactoring, Testing