Xeeynamo / sotn-decomp

Decompilation of Castlevania: Symphony of the Night (PSX+Saturn)
https://sotn.xee.dev/
GNU Affero General Public License v3.0
508 stars 55 forks source link

Improve make-config speed and usability #1647

Closed Xeeynamo closed 1 month ago

Xeeynamo commented 1 month ago

image

Adds a spinner used as an indicator that the tool is working. I broke down the duplicate function finder into multiple steps to give faster feedback to the user.

I am now checking the duplicates only between overlays that make sense to search to. Splitting ric will only cross-reference it with ric us. Same for the servants, stages and the sel stage. On my machine this change trimmed down the execution time from 1m25s to just 10s.

The spinner is very easy to use. Just use spinner_start instead of print. Use spinner_stop(True) to terminate it and go to a new line, but a new spinner_start will do that for you. Use spinner_stop(False) when an operation fails.

This can be merged independently from #1643 and #1644.