Xeeynamo / sotn-decomp

Decompilation of Castlevania: Symphony of the Night (PSX+Saturn)
https://sotn.xee.dev/
GNU Affero General Public License v3.0
508 stars 55 forks source link

Gigantic cleanup PR - remove generic.unk84; dedupe NO3/NP3 #1802

Closed bismurphy closed 4 weeks ago

bismurphy commented 4 weeks ago

This is a ton of material - my apologies.

I started by removing uses of generic.unk84 from the repo, by either creating new Ext members, or making entities use the existing ones. Once I got to doing this on NO3 and NP3, I got frustrated by needing to make the same changes on both overlays, so I decided to de-duplicate them and then just remove generic.unk84 from the de-duplicated single set of code.

This includes some importing of data, some changes to functions to make them match on PSP, etc. Lots of little changes to cleanup.

But no new decompilation in this PR. All just cleanup to rewrite things to be more neat.