search

Xeeynamo / sotn-decomp

Decompilation of Castlevania: Symphony of the Night (PSX+Saturn)
https://sotn.xee.dev/
GNU Affero General Public License v3.0
508 stars 55 forks source link

Decompile PSP DRA file 63C90.c #1861

Closed bismurphy closed 1 week ago

bismurphy commented 2 weeks ago

Decided to tackle this whole file. It mostly matches with the existing DRA, so I've been back-porting the required changes to get the matches. Everything here matches in both.

The only issue is the deadstripping, which we still need to figure out.

I'm not sure why there's a file split at the end of this PSP file, where there isn't one in the PS1 game. I'll try removing the split once the functions are done on each side of the split.

Also adjusted the makefile filter logic so that we only need to give the name of the file, rather than the full path. This makes the file list more concise. If we run into collisions (two files of the same name, in different overlays, which need different optimizations) we can revisit this.

Xeeynamo commented 2 weeks ago

It looks good on my side. I am on my way to fix the progress script. We can merge this afterwards to test if the progress report works as expected.

Xeeynamo commented 1 week ago

I underestimate some level of changes needed to make the new progress check to work. @bismurphy would you mind modifying .github/workflows/validate-and-report.yml on the first FROGRESS_API_BASE_URL: ${{ secrets.FROGRESS_API_BASE_URL }} to do FROGRESS_API_BASE_URL: "https://progress.deco.mp" instead? I think since you do not have the secrets the CI fails. Sorry about the annoyance.