Remove PR bot - Githubissues

Xeeynamo / sotn-decomp

Decompilation of Castlevania: Symphony of the Night (PSX+Saturn)

https://sotn.xee.dev/

GNU Affero General Public License v3.0

508 stars 55 forks source link

Remove PR bot #1890

Closed Xeeynamo closed 5 days ago

Xeeynamo commented 6 days ago

It was a funny little experiment that it was worth trying. Unfortunately it had to major flaws:

There is no easy way to update an existing comment without some scripting, use of tokens and PR manipulation through the GitHub API. It was simply not worth it.
If the opened PR does not have the very latest changes from the default branch, it will report a drop in progress, which is obviously not correct. I could have internally rebased the PR before calculating the changed progress, but it has its own challenges like having to deal with conflicts.

Xeeynamo commented 6 days ago

CI is failing due to --markdown being removed while GitHub Actions is running the CI program from master. Nothing to be worried about

Xeeynamo commented 6 days ago

I was thinking more like just turning it off in the CI, maybe this is useful for debugging the script? Other than that seems good

I thought about that as well. But it would be easier to just checkout the PR branch locally and do a dry-run of the progress script. Maybe later on I can experiment a separate GH Actions workflow that just gets triggered when tools/progress.py changes. But for now my highest priority is to avoid spamming on PRs