Xeio / WanderLost

Lost Ark Wandering Merchant Tracker
MIT License
106 stars 36 forks source link

Feature request: conditional notification cancelling #123

Closed Xane48 closed 2 years ago

Xane48 commented 2 years ago

Pretty simple core idea, disable the notification if you've already upvoted the merchant stock.

For example, I have notifications set to 10 upvotes on Legendary Rapport items. If I submit the merchant stock then it's automatically upvoted, I don't need a notification 5 minutes later when 9 other people go and confirm.

Xeio commented 2 years ago

This should at least mostly work now, at least for notifications directly from the site. There's a few cases where you might still get a ding (like if you have thresholds set to zero votes) due to the way notifications trigger before the first vote is technically registered.

Push notifications are a fair bit "dumber" in that they don't have any sort of user identifier associated with the subscription, so there's unlikely to ever be a way to stop those for merchants you submit.