Xeio / WanderLost

Lost Ark Wandering Merchant Tracker
MIT License
107 stars 35 forks source link

ActiveMerchantGrid UI improvements #56

Closed Cyco0815 closed 2 years ago

Cyco0815 commented 2 years ago
Xeio commented 2 years ago

So just to be clear how this works, it greys out only the 2nd/3rd/etc row?

Looks good though, other than the extra comment I marked above. I'm assuming it can be removed since the sorting still appears to be working.

Related I should really add some dummy test images for the fake zones...

Cyco0815 commented 2 years ago

Yes it only greys out additional merchants. I found it looks really odd if the first merchant is greyed out aswell. On that note: I chose not to completely hide/remove merchants over the downvote threshold, since it might be confusing to see merchants disappear (and users can't suggest them again, they will be blocked in MerchantHub), and I didn't want to add logic to completely remove a merchant server-side.

Oh yeah, the marked line can be removed, the actual sorting happens in the view, not the list. That's from testing, I forgot to remove that. Shame on me...