search

Xelson / flarum-ext-chat

☁️NeonChat — native realtime chat application for Flarum
https://discuss.flarum.org/d/25361-neon-chat-native-realtime-chat-applicaiton
MIT License
20 stars 8 forks source link

ButtonsPadding is too high #8

Closed SKevo18 closed 2 years ago

SKevo18 commented 3 years ago

Before:

After:

You could just add margin-top to the save button as well, so you don't need the padding element

Wadera commented 3 years ago

I think this this extra padding is make in purpuse to give space for popup with search results:

image

image

If we want to improve it - we can try to make this space more dynamic and making in count of number results.

askvortsov1 commented 3 years ago

I think this this extra padding is make in purpuse to give space for popup with search results:

This is correct; with this change, the buttons get covered.

SKevo18 commented 3 years ago

I personally don't think that the padding should be there. Its normal that dropdowns cover things. Or, you could make the padding more dynamic. But the current padding isn't very pleasant on eyes and the blank space & tall modal look strange

askvortsov1 commented 3 years ago

I personally don't think that the padding should be there. Its normal that dropdowns cover things. Or, you could make the padding more dynamic. But the current padding isn't very pleasant on eyes and the blank space & tall modal look strange

Problem is, then the dropdown is cut off. Oh, and it doesn't go away as long as users are selected. Needs a rewrite but I don't have the time or interest.

SKevo18 commented 3 years ago

Needs a rewrite but I don't have the time or interest.

That's okay, it's just a visual bug so it's not urgent