search

Xemorr / superheroes

This is a spigot plugin that adds superpowers to Minecraft!
The Unlicense
11 stars 13 forks source link

Dupe exploit #49

Open Minecrafter8001 opened 2 days ago

Minecrafter8001 commented 2 days ago

What minecraft version did it occur on? 1.21.1 What superheroes version did it occur on? 6.1.2 Description of the issue: dupe exploit with speleologist allows you to dupe Redstone dust by placing it and breaking it

Xemorr commented 2 days ago

For now, go into the speleologist yml file and disable Redstone doubling

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: minecrafter8001 @.> Sent: Friday, November 29, 2024 5:27:48 PM To: Xemorr/superheroes @.> Cc: Subscribed @.***> Subject: [Xemorr/superheroes] Dupe exploit (Issue #49)

What minecraft version did it occur on? 1.21.1 What superheroes version did it occur on? 6.1.2 Description of the issue: dupe exploit with speleologist allows you to dupe Redstone dust by placing it and breaking it

— Reply to this email directly, view it on GitHubhttps://github.com/Xemorr/superheroes/issues/49, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHSVCMVXLR2QI7PTLXXHSZT2DCPZJAVCNFSM6AAAAABSXQFR2CVHI2DSMVQWIX3LMV43ASLTON2WKOZSG4YDKNZSHEZTSNI. You are receiving this because you are subscribed to this thread.Message ID: @.***>

mnmnk43434 commented 2 days ago

Hello, we tried to solve the issue.

This is what we did:

Modified the ConvertDropsSkill class to prevent Redstone dust duplication when placed and broken by a player with the Speleologist power. The fix involves checking if the broken block is Redstone and skipping the conversion process for it.

You can review changes in this commit: https://github.com/mnmnk43434/Xemorr-superheroes-49/commit/5c6a5865cc49e54adcba7e4f9cebc7ba9c113e00.

[!CAUTION] Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

Xemorr commented 2 days ago

This is not how you write maintainable code. There are many uses of the ConvertibleDrops skill that would cause dupes, it needs a config oriented approach. Your description does not make it sound like it satisfies that

Sent from Outlook for Androidhttps://aka.ms/AAb9ysg

From: mnmnk43434 @.> Sent: Friday, November 29, 2024 5:50:01 PM To: Xemorr/superheroes @.> Cc: Samuel Hollis @.>; Comment @.> Subject: Re: [Xemorr/superheroes] Dupe exploit (Issue #49)

Hello, we tried to solve the issue.

This is what we did:

Modified the ConvertDropsSkill class to prevent Redstone dust duplication when placed and broken by a player with the Speleologist power. The fix involves checking if the broken block is Redstone and skipping the conversion process for it.

You can review changes in this commit: @.***https://github.com/mnmnk43434/Xemorr-superheroes-49/commit/5c6a5865cc49e54adcba7e4f9cebc7ba9c113e00.

Caution

Disclaimer: The concept of solution was created by AI and you should never copy paste this code before you check the correctness of generated code. Solution might not be complete, you should use this code as an inspiration only.

If you no longer want Latta AI to attempt solving issues on your repository, you can block this account.

— Reply to this email directly, view it on GitHubhttps://github.com/Xemorr/superheroes/issues/49#issuecomment-2508207245, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AHSVCMTFR4B66LXDPODKQAT2DCSMTAVCNFSM6AAAAABSXQFR2CVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKMBYGIYDOMRUGU. You are receiving this because you commented.Message ID: @.***>