search

XengShi / materialYouNewTab

A Simple New Tab ( browsers's home page ) inspired with Google's 'Material You' design
1.31k stars 124 forks source link

Weather Display Issue: "Feels" & "Earth" Shown Instead of Actual Location #84

Open XengShi opened 3 hours ago

XengShi commented 3 hours ago

We are experiencing weather-related issues. After opening the browser or a new tab, it always shows 'Feels' and 'Earth' instead of the actual location and the feels-like temperature. However, refreshing the tab by pressing Ctrl + Shift + R displays the information correctly. I suspect that some translation code may be affecting this.

I am getting this in Chrome (Checked on Windows) for Firefox it works fine.

@prem12321kumar @itz-rj-here @Minuga-RC

Minuga-RC commented 3 hours ago

This is not because of translation code it's because of that api you guys have used to get the current location information it sometimes just gets ratelimited or something and just refuses to give the location and because of that weather api get confused and returns nothing

Minuga-RC commented 3 hours ago

I will look into an another way of getting location info in the rewrite v3 I'm making rn

Minuga-RC commented 3 hours ago

I will make a temporarily fix for now tomorrow By saving the location in local storage @XengShi

Anyway I'm going to sleep now gn

XengShi commented 3 hours ago

Even gettting on firefox too.

https://github.com/user-attachments/assets/4273d3c4-5187-47ca-9971-e172450985ee

@Minuga-RC Thanks for figuring it out, Good night 😴

ceskyDJ commented 3 hours ago

Hmm, it works well for me (with Brno set via GPS coordinates). I use the current version of the main branch (https://github.com/XengShi/materialYouNewTab/commit/71de98d07df892c684815519d49803df5bb35257). So, maybe rate-limiting is applied, as @Minuga-RC noted.

prem12321kumar commented 1 hour ago

We are experiencing weather-related issues. After opening the browser or a new tab, it always shows 'Feels' and 'Earth' instead of the actual location and the feels-like temperature. However, refreshing the tab by pressing Ctrl + Shift + R displays the information correctly. I suspect that some translation code may be affecting this.

I am getting this in Chrome (Checked on Windows) for Firefox it works fine.

@prem12321kumar @itz-rj-here @Minuga-RC

yeah, I also think this might be because of some translation code. I cant recreate this bug but from the video at 0.33, it's not that it's unable to fetch weather data, since it's showing temp and humidity. if so then commenting two translating lines should temp fix this for now. #86 #87 I will check more tomorrow.