Open prem12321kumar opened 2 days ago
After changing the language getting Undefined location and empty Feels like temp
@XengShi please merge #86 to fix it
@XengShi, also could you please check and merge the other functional PRs at your convenience?
And display PR #89 (confirm if this view is acceptable)
Also, PR #93 is good to go. Thanks
Everything seems perfect now. @prem12321kumar Bhai bahut achha kaam kiya hai aapne, tomorrow I will release it
Thanks a lot! I am learning a lot with all of this.
Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!
Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!
Actually, I did try it, but there was bugs. I put it on hold and planned to try again later. I was also working on translating numerals in some languages like Bengali, and fallback to English if the translation was missing for any particular language. None of it was working properly. Maybe in comming weeks or so, if I can correct it and not solved by anyone else till then, I'll raise a request for a pull merge.
I was checking my fork to ensure everything was fine and found some unwanted things This alert should be translated as well or not, not sure. Thoughts?
In Bangla this translation is bit longer, should we translate it to just āĻ¨āĻŋāĻā§āĻ° āĻĒā§āĻ°āĻā§āĻ¸āĻŋ āĻšā§āĻ¸ā§āĻ āĻāĻ°ā§āĻ¨ (Host your proxy) instead of 'Host your own proxy'?
and the change I did in userText to remove placeholder text when the user starts editing and restore placeholder if the user leaves it empty after clicking, It works for English only as placeholder text "Click here to edit" is hardcoded in the focus and blur event listeners.
In Bangla this translation is bit longer, should we translate it to just āĻ¨āĻŋāĻā§āĻ° āĻĒā§āĻ°āĻā§āĻ¸āĻŋ āĻšā§āĻ¸ā§āĻ āĻāĻ°ā§āĻ¨ (Host your proxy) instead of 'Host your own proxy'?
and the change I did in userText to remove placeholder text when the user starts editing and restore placeholder if the user leaves it empty after clicking, It works for English only as placeholder text "Click here to edit" is hardcoded in the focus and blur event listeners.
You are good to go with that. It should be āĻ¨āĻŋāĻā§āĻ° āĻĒā§āĻ°āĻā§āĻ¸āĻŋ āĻšā§āĻ¸ā§āĻ āĻāĻ°ā§āĻ¨.
Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!
finally done. lol the issue was in index.html, reordered language.js and script.js
btw, for me weatherAPI always fetch wrong location from IPv4 address. Reason why I use manual inputted location. đ