XengShi / materialYouNewTab

A Simple New Tab ( browsers's home page ) inspired with Google's 'Material You' design
1.33k stars 124 forks source link

Weather Display issue when weatherTextCondition is long #97

Open prem12321kumar opened 2 days ago

prem12321kumar commented 2 days ago

image image

btw, for me weatherAPI always fetch wrong location from IPv4 address. Reason why I use manual inputted location. 😅

XengShi commented 1 day ago

Screenshot from 2024-10-22 21-03-58

After changing the language getting Undefined location and empty Feels like temp

prem12321kumar commented 1 day ago

@XengShi please merge #86 to fix it

prem12321kumar commented 1 day ago

@XengShi, also could you please check and merge the other functional PRs at your convenience?

104: script.js file (languages.js and index.js have already been merged)

98 and #99: Czech date formatting

And display PR #89 (confirm if this view is acceptable)

Also, PR #93 is good to go. Thanks

XengShi commented 1 day ago

Everything seems perfect now. @prem12321kumar Bhai bahut achha kaam kiya hai aapne, tomorrow I will release it

prem12321kumar commented 1 day ago

Thanks a lot! I am learning a lot with all of this.

XengShi commented 1 day ago

Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!

prem12321kumar commented 1 day ago

Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!

Actually, I did try it, but there was bugs. I put it on hold and planned to try again later. I was also working on translating numerals in some languages like Bengali, and fallback to English if the translation was missing for any particular language. None of it was working properly. Maybe in comming weeks or so, if I can correct it and not solved by anyone else till then, I'll raise a request for a pull merge.

prem12321kumar commented 23 hours ago

I was checking my fork to ensure everything was fine and found some unwanted things image This alert should be translated as well or not, not sure. Thoughts?

image In Bangla this translation is bit longer, should we translate it to just āĻ¨āĻŋāĻœā§‡āĻ° āĻĒā§āĻ°āĻ•ā§āĻ¸āĻŋ āĻšā§‹āĻ¸ā§āĻŸ āĻ•āĻ°ā§āĻ¨ (Host your proxy) instead of 'Host your own proxy'?

and the change I did in userText to remove placeholder text when the user starts editing and restore placeholder if the user leaves it empty after clicking, It works for English only as placeholder text "Click here to edit" is hardcoded in the focus and blur event listeners.

itz-rj-here commented 6 hours ago

In Bangla this translation is bit longer, should we translate it to just āĻ¨āĻŋāĻœā§‡āĻ° āĻĒā§āĻ°āĻ•ā§āĻ¸āĻŋ āĻšā§‹āĻ¸ā§āĻŸ āĻ•āĻ°ā§āĻ¨ (Host your proxy) instead of 'Host your own proxy'?

and the change I did in userText to remove placeholder text when the user starts editing and restore placeholder if the user leaves it empty after clicking, It works for English only as placeholder text "Click here to edit" is hardcoded in the focus and blur event listeners.

You are good to go with that. It should be āĻ¨āĻŋāĻœā§‡āĻ° āĻĒā§āĻ°āĻ•ā§āĻ¸āĻŋ āĻšā§‹āĻ¸ā§āĻŸ āĻ•āĻ°ā§āĻ¨.

prem12321kumar commented 6 hours ago

Hey, what do you think about translating the greeting messages (like Good Morning, Good Evening, etc.) into regional languages? Since you've already worked on similar tasks, I understand it may not offer much in terms of learning something new. If you're interested, feel free to work on it only when you have some free time!

finally done. lol the issue was in index.html, reordered language.js and script.js