search

XenitAB / terraform-modules

Xenit Terraform modules
MIT License
33 stars 18 forks source link

Governance: make service_principal_all_owner_name optional #1138

Closed CalleB3 closed 2 weeks ago

CalleB3 commented 2 months ago

service_principal_all_owner_name is currently mandatory to input, there are cases where we dont want to force this. e.g when delegate_sub_groups = false and we havent created the all-owner, all-contributor, all-readers groups.

Implement the same logic as we currently use in aad-group-sub-delegation.tf so that it will be controlled via the delegate_sub_groups variable.

@linus-lysell brough this issue

landerss1 commented 2 weeks ago

Fixed by #1139.