Xeno69 / Domination

Domination - A MP mission for Arma 3
83 stars 36 forks source link

mini-camp objects are not correctly placed on the ground and hover in the air #189

Closed longtimegamer closed 3 years ago

longtimegamer commented 4 years ago

Floating objects around the mini-camp. This is a problem on Altis and Malden and maybe others.

image

Xeno69 commented 4 years ago

Specific island and/or mod/addon? I've never seen it even with 40 players on a server

longtimegamer commented 4 years ago

No mods. I have seen this bug on every map (including CUP maps) since the mini-camps were added. It is easy to reproduce. Almost every maintarget shows at least a one object floating in the air. I see it in almost every game session...

Xeno69 commented 4 years ago

I have exactly never seen the problem on any map :( Not once.

Xeno69 commented 4 years ago

Whatever I try, I can't reproduce it :(

longtimegamer commented 4 years ago

Maybe from the pull request I submitted in 5/2020 and d_EnableSimulationCamps...

if (_superSimple) then {
    //World coords are used
    _object = createSimpleObject [_p3d, _pos, _loc];
} else {
    if (d_EnableSimulationCamps > 0) then {
        _object = createVehicle [_class, _pos, [], 0, "NONE"];
    } else {
        //ASL coords are used; fixed later by ASL to World offset
        _object = createSimpleObject [_class, AGLToASL _pos, _loc];
    };
};

Something with createVehicle vs createSimpleObject and position translation... I probably broke something but I don't think anyone else uses that setting. :)

longtimegamer commented 4 years ago

139 looks really suspicious. I removed added AGLToASL and I don't remember why...

longtimegamer commented 3 years ago

Everything seems to be working correctly.

This commit and diff for fn_createsimpleobject.sqf is interesting:

https://github.com/Xeno69/Domination/compare/b5602f1..247a87e#diff-a5d7c45397850422ff53b8ebfb509f0672bf004fac78cfaeadfc1ee1dfbd0a98

In that old commit I changed from _pos to AGLToASL _pos. I'm not sure how it worked before that change. When I remove AGLToASL the tents and other items are always underground.

I am not sure why or how I was seeing the previous problem. I will close this issue since it works correctly now.