search

Xenon257R / blue-archive-rainmeter

A Blue Archive themed Rainmeter suite for your Windows desktop.
MIT License
127 stars 4 forks source link

I would like to use Youtube Music in this music player. #2

Closed GTK0326 closed 1 year ago

GTK0326 commented 1 year ago

I think it would be great if you add this feature in next versions. I only use youtube music for music subscription service. But, NowPlaying can't support it. (https://docs.rainmeter.net/manual/measures/nowplaying/) WebNowPlaying is used by using a BrowserExtension, and it can be added to the official Spotify Player using Spicetify, so I think it will be usefull if you add it.

Thanks.

GTK0326 commented 1 year ago

I did it myself. So, close this issue. What is needed is to replace this: Before: Measure=WebNowPlaying PlayerName=[MeasurePlayer]

After: Measure=Plugin Plugin=WebNowPlaying

Xenon257R commented 1 year ago

I did it myself. So, close this issue. What is needed is to replace this: Before: Measure=WebNowPlaying PlayerName=[MeasurePlayer]

After: Measure=Plugin Plugin=WebNowPlaying

Thanks for providing the solution after you figured it out! This sounds like a good feature to implement in future versions for others' convenience 100%, so I'd just like to confirm whether this small change seamlessly worked with the MusicPlayer as-is or it created new issues like making certain buttons not work anymore or variables like TrackName no longer working.

Right out the gate, it does look like we had to change a Variable type from PlayerName to Plugin, so this may warrant a new MusicPlayer variant instead of a changeable value for user friendliness. I also assume you had to make this change for the Visualizer and AudioVisualizer as well (if you're using them).

GTK0326 commented 1 year ago

so I'd just like to confirm whether this small change seamlessly worked with the MusicPlayer as-is or it created new issues like making certain buttons not work anymore or variables like TrackName no longer working.

In my env, these buttons are working: Play/Pause, Previous, Next, Back, Forward, Close, Duration Bar/Current/Full, Volume Bar/Current Volume Up/Down. Of Cource, the music title and artist name is working. Repeat, Shuffle, Stop buttons are not working, but I think a little fix make it work. ( But, I don't do so, because I don't need thier buttons much)

this may warrant a new MusicPlayer variant instead of a changeable value for user friendliness.

I think so.

I also assume you had to make this change for the Visualizer and AudioVisualizer as well

Thanks. Yes I know that and fixed them yet! AudioVisulaizer also work about music title and artist name.