XenonShawn / pe

0 stars 0 forks source link

Clear function can delete suppliers with supplied items #10

Open XenonShawn opened 1 year ago

XenonShawn commented 1 year ago

image.png

It is not possible to delete a supplier if they have supplied food in the inventory, but clear ignores that constraint.

Low severity as it does not impede the usage of the app, but can be medium severity given the next bug report.

nus-se-script commented 1 year ago

Team's Response

No details provided by team.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Clearing from suppliers does not remove their respective supplies from Inventory secion

To reproduce: Have some supplies in Inventory and use the clear command on suppliers

Expected: After clearing, the respective items from inventory should be cleared as well. or at least after clearing, adding a different supplier supplying the same item should modify the current or add a new item in inventory.

Actual: Supplies from the Inventory also get's removed since they contain the cleared suppliers name. This is despite the fact that it is not allowed to delete a supplier when there is inventory from the supplier.

Even if suppose its by design to let them remain past clear command, afterwards, adding another supplier providing the same supply and trying to add their supply to Inventory is not allowed. i.e. changing suppliers through deleting and adding a different supplier.

image.png


[original: nus-cs2103-AY2223S1/pe-interim#1030] [original labels: severity.Medium type.FunctionalityBug]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

No details provided by team.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue severity

Team chose [severity.Medium] Originally [severity.Low]

Reason for disagreement: [replace this with your explanation]