XereoNet / SpaceGDN

Game Delivery Network for SpaceCP (and beyond!)
GNU Affero General Public License v3.0
8 stars 3 forks source link

Leaking temporary files #42

Open tlaundal opened 10 years ago

tlaundal commented 10 years ago

Spacegdn seems to be leaking tmp files.

I have verified that it is spacegdn that is leaking by looking at the user owning the tmp files, and when they were created. I have a cron task set up to load new builds each hour, and with / being 20GB, it quickly fills up with temporary files.

connor4312 commented 10 years ago

Can you look at those files and see what they appear to be?

tlaundal commented 10 years ago

There seem to be mostly Nginx 404 error pages and empty directory structures.

One of the directories I found was: ' /tmp/tmpe_ga2ezu/Hexxit_Server_v2.0.0/Chocolate/Building/castles '

I think putting a try-finally around all uses of tmp files, and close them in the finally block, might solve this problem.

connor4312 commented 10 years ago

I kinda want to rework the way modifications work to be a bit more unified, and readable. Might get that done this weekend :)