search

XeresRazor / subler

Automatically exported from code.google.com/p/subler
Other
3 stars 0 forks source link

Removing secondary track and adding a different one will add both #734

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
What steps will reproduce the problem?
1. Open a movie with an AAC track and add an AC3 track
2. Save as a video file
3. Now delete the AC3 track and add a *different* AC3 track
4. Save As a different video file

Result: the new video file will contain the data from both the first AC3 track 
(which you deleted) and the second one.

Expected: the first AC3 track should have been deleted and not be represented 
in the second video file.

Original issue reported on code.google.com by douglass...@gmail.com on 13 Feb 2014 at 3:47

GoogleCodeExporter commented 9 years ago 
"Optimize" will remove the unneeded data.

Original comment by damiog on 13 Feb 2014 at 7:47

GoogleCodeExporter commented 9 years ago 
Thanks, that's good to know - though having to choose an "Optimize" command in 
order to remove data that the user already removed is really awkward. The UI 
updates to show that the user removed that data, so the idea that it's still 
there invisibly (and in a way that can't be used) seems just wrong.

Original comment by douglass...@gmail.com on 13 Feb 2014 at 9:24

GoogleCodeExporter commented 9 years ago 
Removing the "data" is not an easy thing. It means rewriting the entire file, 
slowing down the entire save operation (you want to remove a 10kb subtitle 
track? here, wait two minutes so I can rewrite the entire thing). Actually 
Subler works the save way as Quicktime 7 or every other mov/mp4 app that save 
the changes in-place.

Original comment by damiog on 13 Feb 2014 at 9:28

GoogleCodeExporter commented 9 years ago 
Note in my original steps I'm doing a Save As, which inherently rewrites the 
entire file. MS Word works like this: deleted text is not actually deleted from 
the file when you Save, but if you Save As you get a clean copy.

Original comment by douglass...@gmail.com on 13 Feb 2014 at 9:37

GoogleCodeExporter commented 9 years ago 
Yes, Save As makes a copy and then saves the change on it. It needs to be fixed.

Original comment by damiog on 14 Feb 2014 at 8:48