search

XeroAPI / Xero-NetStandard

A wrapper of the Xero API in the .NetStandard 2.0 framework. Supports Accounting, Payroll AU/US, and Files
MIT License
126 stars 124 forks source link

Add support for ALEUTIANSTANDARDTIME timezone #444

Closed Tim-Hodge closed 1 year ago

Tim-Hodge commented 2 years ago

SDK you're using (please complete the following information):

Describe the bug The ALEUTIANSTANDARDTIME timezone is not supported within Xero.NetStandard.OAuth2.Model.Accounting.TimeZone. Any calls to GetOrganisationsAsync (/Organisation) that return "Timezone": "ALEUTIANSTANDARDTIME" will fail to deserialise.

To Reproduce

  1. Go to /Setup/FinancialSettings.aspx
  2. Set timezone to (UTC-10:00) Aleutian Islands
  3. Attempt an API call to GetOrganisationsAsync (/Organisation) with the client library
  4. Receive null in response. Internal error is: Error converting value “ALEUTIANSTANDARDTIME” to type ‘Xero.NetStandard.OAuth2.Model.Accounting.TimeZone’. Path ‘Organisations[0].Timezone’, line 30, position 40

Expected behavior Expect deserialised object with correct timezone to be returned. I would also expect an exception to be thrown in future cases, as opposed to a null return.

Abhisha1 commented 2 years ago

Hi @Tim-Hodge Thanks for raising this issue. I have been able to reproduce and am currently working on pushing out a fix for this.

Thanks again :)

Abhisha1 commented 1 year ago

Hi Tim! We've released the fix for this in version 3.29.1 so I'm marking this issue as resolved.

Have a great day 😄