search

XeroAPI / Xero-NetStandard

A wrapper of the Xero API in the .NetStandard 2.0 framework. Supports Accounting, Payroll AU/US, and Files
MIT License
126 stars 124 forks source link

AccountingApi does not follow .NET naming conventions #447

Closed lloydjatkinson closed 1 year ago

lloydjatkinson commented 1 year ago

SDK you're using (please complete the following information):

    <PackageReference Include="Xero.NetStandard.OAuth2" Version="3.29.1" />
    <PackageReference Include="Xero.NetStandard.OAuth2Client" Version="1.6.0" />

Describe the bug The Contacts property has an underscore prefix which is not a conventional name for a property. Following idioms of a language should be an expected feature.

        [DataMember(Name = "Contacts", EmitDefaultValue = false)]
        public List<Contact> _Contacts { get; set; }
JRising-Xero commented 1 year ago

Hi @lloydjatkinson, Completely agree with you, unfortunately, aligning our SDK with correct conventions would be a major breaking change. As such changes to correct this will have to be postponed until a complete overhaul of the SDK occurs. Apologies for the inconvenience.