search

XeroAPI / Xero-NetStandard

A wrapper of the Xero API in the .NetStandard 2.0 framework. Supports Accounting, Payroll AU/US, and Files
MIT License
126 stars 124 forks source link

BatchPayment info is missing inside the payment response object #449

Closed thusithagh closed 1 year ago

thusithagh commented 1 year ago

Xero.NetStandard.OAuth2 3.29.1 Xero.NetStandard.OAuth2Client 1.6.0

No property to hold batch payment information, within the Xero.NetStandard.OAuth2.Model.Accounting.Payment class.

To Reproduce Steps to reproduce the behavior:

  1. Go to API explorer

  2. Make a request to Accounting/GetPayments endpoint against the Demo org

  3. Notice the BatchPayment property under each Payment image

  4. Use Xero.NetStandard.OAuth2 to make the same request.

  5. Notice that the BatchPayment is not captured in Xero.NetStandard.OAuth2.Model.Accounting.Payment` class, and there isn't even a property to hold this information.

image

Expected behavior There should be a property to hold batch payment information, under each payment. This is readily available in the API, so it should be about just having a new property and the values assigned to it on successful response.

It will be great help if we have all the information received via the API, in all the response objects in Xero.NetStandard.OAuth2.Model.Accounting

Best regards, Thusitha H

JRising-Xero commented 1 year ago

Hi Thusitha, Thanks for raising this issue, we agree that the batch payment property should be apart of the payment model. We have gone ahead and released this change in the latest SDK release (3.29.2), view the release notes here for more details.

image

Thanks.