XeroAPI / Xero-NetStandard

A wrapper of the Xero API in the .NetStandard 2.0 framework. Supports Accounting, Payroll AU/US, and Files
MIT License
120 stars 119 forks source link

GET Contacts cannot handle long list of IDs #471

Open Tim-Hodge opened 1 year ago

Tim-Hodge commented 1 year ago

SDK you're using (please complete the following information): 3.31.0

Describe the bug When calling GET /Contacts with a long list of IDs the response will be 404 The resource you're looking for cannot be found

To Reproduce Steps to reproduce the behavior:

  1. Call GetContactsAsync with a list of IDs > 56 or
  2. Call GET https://api.xero.com/api.xro/2.0/Contacts?IDs=... with a total URL length of >2091

Expected behavior Expect a list of Contacts to be returned, or a helpful error to indicate that the URL was too long and could not be processed

Additional context I've tested this out both with the SDK and against the API and it appears common to both. Unsure if this is also prevalent on other endpoints. I have tested IDs in the list independently and failure only occurs when the character count exceeds a limit. Limit can be reached/tested granularly by padding with an additional param, e.g. https://api.xero.com/api.xro/2.0/Contacts?IDs=[ids..]&padding=aaa

github-actions[bot] commented 1 year ago

PETOSS-281

github-actions[bot] commented 1 year ago

Thanks for raising an issue, a ticket has been created to track your request