XeroAPI / Xero-NetStandard

A wrapper of the Xero API in the .NetStandard 2.0 framework. Supports Accounting, Payroll AU/US, and Files
MIT License
118 stars 119 forks source link

UK Payroll API returning EarningsRateID as EarningsLineID in GetPaySlipsAsync #481

Open benedict-odonovan opened 1 year ago

benedict-odonovan commented 1 year ago

SDK you're using (please complete the following information):

Describe the bug When viewing the EarningsLines Property of a UK Payslip the EarningsLineID is incorrect and is set to be the EarningsRateID instead.

e.g.

{
  EarningsLineID: 74a6a571-884c-4c7e-aa94-824c0770053b
  EarningsRateID: 74a6a571-884c-4c7e-aa94-824c0770053b
  DisplayName: Regular Hours
  RatePerUnit: 111
  NumberOfUnits: 1
  FixedAmount: null
  Amount: 111
  IsLinkedToTimesheet: False
  IsAverageDailyPayRate: null
}

To Reproduce Steps to reproduce the behavior:

  1. Call xeroApi.PayrollApi.GetPaySlipsAsync(xeroApi.AccessToken, xeroApi.XeroTenantId, payRunID, page: 1)
  2. View any earnings line underneath the payslip's EarningsLines collection

Expected behavior The EarningsLineID should be unique and specific to the earnings line.

github-actions[bot] commented 1 year ago

PETOSS-308

github-actions[bot] commented 1 year ago

Thanks for raising an issue, a ticket has been created to track your request

benedict-odonovan commented 1 year ago

Just noticed the OpenAPI documentation is incorrect in their example of the PaySlips API too, showing the same GUID for the rate and line ID.

Let me know if I need to open an issue there instead.

https://github.com/XeroAPI/Xero-OpenAPI/blob/master/xero-payroll-uk.yaml