XeroAPI / Xero-NetStandard

A wrapper of the Xero API in the .NetStandard 2.0 framework. Supports Accounting, Payroll AU/US, and Files
MIT License
118 stars 119 forks source link

`Reference` and `Details` on `BatchPaymentDetails` cannot be saved on a `Contact` #488

Open dgurram opened 9 months ago

dgurram commented 9 months ago

SDK you're using (please complete the following information):

Describe the bug Creating a Contact with BatchPayments set has no effect for an Australian Xero contact. I just want to set the Reference field so that all payments automatically get this reference by default. I have tried setting the Reference field as well as the Details field (on Contact.BatchPayments), I've also tried setting both as below, and the SDK does not complain, yet the value is never reflected back on a GET, not visible on the UI and not present when generating payments. So my conclusion is that it's not being accepted and saved:

BatchPayments = new BatchPaymentDetails
{
    Details = "MyDefaultReference",
    Reference = "MyDefaultReference"
}

The documentation does say these are both NZ Only: https://github.com/XeroAPI/Xero-NetStandard/blob/master/Xero.NetStandard.OAuth2/Model/Accounting/BatchPaymentDetails.cs#L62

But is there a reason this can't be supported for Australia too? The Xero UI does support saving this - Financial Details -> Reference. It's somehow not supported by the API, yet the API does not return a 4xx error, it just silently accepts the value but doesn't actually save it.

Expected behavior Setting BatchPayments in a contact creation via the API should allow the Reference and/or Details to be saved.

github-actions[bot] commented 9 months ago

PETOSS-356

github-actions[bot] commented 9 months ago

Thanks for raising an issue, a ticket has been created to track your request