search

XeroAPI / xero-php-oauth2

Xero PHP SDK for oAuth 2 generated from Xero API OpenAPI Spec 3.0
MIT License
87 stars 64 forks source link

Employee missing properties (NI category) #273

Open csnuknet opened 2 years ago

csnuknet commented 2 years ago

SDK you're using (please complete the following information):

Describe the bug When using the latest PHP SDK the following properties aren't exposed but are present in the returned response (as validated with the API explorer), these attributes also do not seem to be present in the Open API spec used to generate the SDK.

"niCategory": "A", "niCategories": [ { "startDate": null, "niCategory": "A", "niCategoryID": 1657128 } ], "employeeNumber": "10",

To Reproduce

Call ->getEmployee() on the SDK vs a direct call to the endpoint. https://api.xero.com/payroll.xro/2.0/employees/{employeeID}

Expected behavior Provide feature parity with the endpoint response data, thus exposing the properties.

pumpkinball commented 1 year ago

Hi @csnuknet yes, it does appear to be missing this niCategories array. I'm just waiting for confirmation over the exact properties of the array, and then we'll add into the OpenAPI spec for all languages, and then we'll generated the next PHP SDK with it in all being well. Thanks for finding it!