search

XeroAPI / xero-php-oauth2

Xero PHP SDK for oAuth 2 generated from Xero API OpenAPI Spec 3.0
MIT License
87 stars 64 forks source link

PHP Deprecated: Creation of dynamic property. PHP 8.2 #318

Open YuraKril opened 1 year ago

YuraKril commented 1 year ago

Describe the bug PHP Deprecated: Creation of dynamic property XeroAPI\XeroPHP\JWTClaims::$preferred_username is deprecated

github-actions[bot] commented 1 year ago

PETOSS-276

github-actions[bot] commented 1 year ago

Thanks for raising an issue, a ticket has been created to track your request

YuraKril commented 1 year ago

Hello team. Any updates on the issue?

pumpkinball commented 1 year ago

Hi @YuraKril thanks for picking up this, and for submitting your PR. I've changed it slightly so that the decodeIdToken function is setting $this->username. Then the getPreferredUsername function will work in both scenarios.

YuraKril commented 1 year ago

Hi @pumpkinball . When will these changes be available?