EASTERISLANDSTANDARDTIME timezone support seems to be missing

XeroAPI / xero-ruby

Xero Ruby SDK for OAuth 2.0 generated from XeroAPI/Xero-OpenAPI

http://developer.xero.com/

MIT License

58 stars 91 forks source link

EASTERISLANDSTANDARDTIME timezone support seems to be missing #189

Closed saboter closed 3 years ago

saboter commented 3 years ago

Hello,

one of our US clients tried to connect Xero organisation with time zone which is missing in:

xero-ruby/models/accounting/time_zone.rb

Exception was thrown during "get_organisations" call processing:

RuntimeError: Invalid ENUM value EASTERISLANDSTANDARDTIME for class #TimeZone

No idea if its some legacy timezone or something super new but it would be nice to have support for it.

wobinb commented 3 years ago

Thanks for letting us know.

This SDK (like the others) is generated from our OpenAPI Specification (OAS) files here: https://github.com/XeroAPI/Xero-OpenAPI/ it would seem that this timezone was missing from the list of ENUMs. I've submitted a PR to add the missing value, once this has been merged, it will appear with the SDK the next time it is auto-generated. You can follow the PR (for the OAS) here: https://github.com/XeroAPI/Xero-OpenAPI/pull/441