search

XeroOl / notitg-mirin

The NotITG Mirin Template. Easily create modfiles using Lua.
https://xerool.github.io/notitg-mirin
The Unlicense
35 stars 16 forks source link

Split func into separate functions for each purpose #49

Closed XeroOl closed 2 years ago

XeroOl commented 2 years ago

The function func is getting extremely overloaded.

    local valid_func_signatures = {
        ['number, function'] = true,
        ['number, number, function'] = true,
        ['number, number, ease, function'] = true,
        ['number, number, ease, string'] = true,
        ['number, number, ease, number, function'] = true,
        ['number, number, ease, number, string'] = true,
        ['number, number, ease, number, number, function'] = true,
        ['number, number, ease, number, number, string'] = true,
        ['number, string, ?'] = true,
    }

It would be a good idea to give each of these separate names

XeroOl commented 2 years ago

I think the new name scheme will be func: number, function func: number, string, ? func: number, actor, methodname, args perframe: number, number, function func_ease: number, number, ease, function func_ease: number, number, ease, number, function func_ease: number, number, ease, number, number, function func_ease: number, number, ease, string func_ease: number, number, ease, number, string func_ease: number, number, ease, number, number, string func_ease: number, number, ease, actor, methodname func_ease: number, number, ease, number, actor, methodname func_ease: number, number, ease, number, number, actor, methodname

as you can see, func_ease is doing all the heavy lifting