search

XeroxDev / YTMD-StreamDeck

This Stream Deck Plugin allows you to control the YouTube Music Desktop App (https://github.com/ytmdesktop/ytmdesktop)
MIT License
50 stars 16 forks source link

fix: socket.io updated #41

Closed eltharynd closed 5 months ago

eltharynd commented 2 years ago

Ready for incoming YTMD update.

YTMD has some pull requests to update to current version of socket.io. There has been quite some changes to socket.io and the auth system currently used by YTMD is broken on some browsers.

The reason being custom headers are blocked on WebSockets standards, so socket.io has built in auth functionality to guarantee the token will be passed under all circumstances... I personally pushed the PR to YTMD to update those, and i kept backwards compatibility so this won't break on update, regardless we should still update as soon as it comes out.

⚠️⚠️⚠️ Don't push it NOW because they havn't released the update yet, tho I'm already using my custom build of this plugin with a custom build of YTMD and it works as intended.

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

eltharynd commented 2 years ago

for reference https://github.com/ytmdesktop/ytmdesktop/pull/900

sonarcloud[bot] commented 2 years ago

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

XeroxDev commented 1 year ago

Do you know of any update on this?

XeroxDev commented 5 months ago

I'll close this in favor of #98