search

Xeroxxx / tplink-energy-monitor

An energy monitoring dashboard for TP-Link smart plugs - Forked from https://github.com/jamesbarnett91/tplink-energy-monitor
GNU General Public License v3.0
21 stars 7 forks source link

Feedback dev-2 #23

Open ShagoY opened 3 years ago

ShagoY commented 3 years ago

Hi Xeroxxx :)

I just tested the dev-2, it's really nice!

However I will have some comments/suggestions:

1- I don't really understand the "realtime usage". For example on my raspberry I have 0.1%, what does it mean ? image

2- Since some of my plugs are connected to "Low powered" peripherals, the decimals are important. Do you think you can display them directly on the "realtime usage" dashboard, it's the case for amperage but not for watts. The rounding is far too aggressive on my usage.

3- I think you already know it but the reset curves are not when changing plugs.

4- I use another docker container that allows me to export the stats of my plugs to a Prometheus database for a larger history and display in a Grafana dashboard. Is this something you are considering adding?

Thank you.

nbyx commented 3 years ago

Hi ShagoY, thanks for your feedback.

  1. I admit the "realtime usage"-gauge is a bit confusing. I tried to have here the same look and feel like the original tp link monitor. The problem in my view is the percentage. One might think at 0% you have 0.03A and on 100% 235V. There are two options: Remove the percentage or lable the gauge in a correct way. What is your thought about this?

  2. Sure this should be no problem. How many decimals do you need?

  3. Yes I know this, but honestly I thought it looks not so bad and therefore I did not fix it. :D We will fix it latest when we merge this into master. :)

  4. We want to support the JSON-Files of the original tp-link-monitor but extend it a bit. Is this what you need (timestamp and usage)? Or what stats do you want to export? Could be another thing to add to the device view.

ShagoY commented 3 years ago

Hi :)

1- Thank you, I now understand this gauge. So it's based on the max that the plug supports, it's logical! With the old version we didn't have a text value, that's what confused me. Honestly, I had no interest with this feature already on the old version, I just want to know the amperage/watt/voltage of my plugs ^^

2- Two decimals will be perfect! After that clearly has no interest on values above ten (W/V/A). Maybe the use of "condition" (< 10) will be good for all types of cases.

3- It's clearly not a problem in itself, except when I switch from a plug with more than 250W to my plug controlling my RPIs ^^

4- Currently on the "market", there is only one other Docker container that allows us to extract data from our catches to databases (Influx/Prometheus/etc..). Most of them do it on only one plug! So I use the docker "TP-Link HS110 Data Collector" from Chappio But this one has not been maintained for the last two years. I like Prometheus very much for the way it works (no sending of data, just the creation of a page with the temporal data). With the python library, it's really easy to implement. I know that your app already allows you to see the history but I think that the fact that you can still use your data for other dashboards (like grafana) will be really nice!

nbyx commented 3 years ago

Hi @ShagoY , I recently updated the dev-2.0 branch, and 1-3 are now fixed. 4 is something we should keep in mind for future implementation.

Feel free to test it. :)

Xeroxxx commented 3 years ago

image