search

XervoIO / demeteorizer

Converts a Meteor app into a standard Node.js application.
http://npm.im/demeteorizer
MIT License
703 stars 59 forks source link

Is this necessary with Meteor 1.4 anymore? #225

Open jedwards1211 opened 8 years ago

jedwards1211 commented 8 years ago

It looks like the code in Master is basically just calling meteor build and tweaking its package.json a bit.

I thought it was adding package.json entries for everything in programs/server/npm but it looks like that's not the case.

meteor build is sufficient for 1.4 projects right?

theworkflow commented 8 years ago

IMO it's totally up to the end user to decide if this is still needed. I think so because while it does look like it's only setting up the package.json, it's ensuring that engines are set up and easy to deploy on any infrastructure. While that's the goal, the meteor build command doesn't really do that. On top of that, it allows for custom JSON to be added to the package.json. There are some great things that this module does in the long run.

jedwards1211 commented 8 years ago

I see...I'm guessing that meteor build has gotten closer to outputting a normal node project over the years though?

jedwards1211 commented 8 years ago

It looks like back in the original version it was actually doing a lot more work, like building the list of dependencies manually.

ramijarrar commented 8 years ago

We dropped it while waiting for 1.4 compatibility & taking a closer look at what it was doing relative to the overhead. It only took us a few hours to write a simple script which makes the same modifications to package.json without any of the dependencies.

While I think there is still a place for a tool like this post-build, the way it's written at the moment (which probably dates back to when it was performing more complex tasks) doesn't justify the value it is providing.