XervoIO / demeteorizer

Converts a Meteor app into a standard Node.js application.
http://npm.im/demeteorizer
MIT License
703 stars 59 forks source link

[request] Change the way Modulus deploys a Meteor App #235

Open mycyberacademy opened 7 years ago

mycyberacademy commented 7 years ago

Currently, if I upload a meteor source code to modulus, it does these tasks:

The 2nd step includes installing meteor specific packages, the ones the project uses. If one of those packages makes changes to package.json file, meteor throws a message saying that changes to package.json was made, and meteor npm install needs to be done again.

As a result modulus script halts without success:

Your package.json has been updated. Please, run npm install in your project directory. Conversion failed.

The meteor package who make those changes is called webpack:weback. Please change modulus script so it could notice it has to run npm install again and doesn't halt.

I tested this out with meteor 1.4.1. This will fix #224 too.

jackboberg commented 7 years ago

This is great feedback/research. Some of the changed you are suggesting actually make more sense currently in the build-meteor image issues instead of here. That said, I will spend some time thinking about how the next release of demeteorizer might resolve this (and related) issues instead of just solving it for the Modulus platform.

Thanks @mycyberacademy