search

Xethron / migrations-generator

Laravel Migrations Generator: Automatically generate your migrations from an existing database schema.
MIT License
3.32k stars 588 forks source link

Update MigrateGenerateCommand.php #111

Closed ginzunza closed 6 years ago

ginzunza commented 7 years ago

I added snake_case and camel_case to fix migration and class name error when tables has uppercase name.

Xethron commented 7 years ago

Wouldn't this also change the name of the table?

ginzunza commented 7 years ago

You are right!, I changed this line of code.

Xethron commented 7 years ago

Still not sure if I agree with changing the name of the table, even if it is only to lowercase. Personally, for me, the idea was not to assume a better database design with this project, but to replicate the database exactly.

If you feel strongly about this, I'd recommend making it an optional field you can pass in like --lowercase-table-names or something.

Xethron commented 6 years ago

This PR changes table names. Closing until its resolved