Xeverous / filter_spirit

Advanced item filter generator for Path of Exile that uses it's own DSL and online item price APIs
GNU General Public License v3.0
36 stars 7 forks source link

Including a specific commented section when compiling #19

Closed Alekhoff closed 4 years ago

Alekhoff commented 4 years ago

Hey,

Love this filter generator, its what i have been looking for!

Is there any way to include only some Highlight block that is normally commented out, but i uncomment them if i need to look for a specific item for one or two maps?

So i dont have to uncomment it, then compile, then comment it out again and compile again when I got what i was looking for.

Xeverous commented 4 years ago

Currently, no. This will be solved once the feature of generating multiple filter variants is present. If you have any syntax/semantics idea, post in #7.

Current partial workaround: FS does not generate blocks which would be invalid - so far this only happens when a string condition (class/base type/has explicit mod/has enchantment) has empty list of names. So if you have:

# x = ["something", "you", "want", "to", "pick", "up"]
x = []

Class x {
   ...

by (un)commenting 1 line you can swap between generating and not generating a set of nested blocks that depends on a string-based condition.

Xeverous commented 4 years ago

Do you have any more questions or can this be closed? The actual lacking feature is tracked by #7.

Xeverous commented 4 years ago

Agreed to close on a private message.