Xevrac / t4finalkill

Final Kill Cam mod for Plutonium T4 (MP).
GNU General Public License v3.0
0 stars 0 forks source link

_finalkillcam.gsc does not support nonabsolute endgame() conditions #1

Open Xevrac opened 3 months ago

Xevrac commented 3 months ago

When any gamemode that has a nonabsolute endgame() condition, the Final Kill Cam function fails and doesn't appear. The end of round screen appears like normal.

The issue is the conditions within the script don't handle any endgame() condition that isn't an absolute WIN or LOSS. I.e. Draw/Tie, End of Regulation etc.

Xevrac commented 3 months ago

When playing TDM, and a tie event occurs the following is output in the console.

** script runtime error **
cannot cast undefined to bool: (file 'maps/mp/gametypes/_finalkillcam.gsc', line 646)
    if(!isPlayer(Winner) && !level.doFK[winner])
                                       *
Error: called from:
(file 'maps/mp/gametypes/_finalkillcam.gsc', line 560)
        thread startFK( winner );
               *
Error: started from:
(file 'maps/mp/gametypes/_finalkillcam.gsc', line 555)
    wait 9;
    *
Error: **

** script runtime error **
cannot cast undefined to bool: (file 'maps/mp/gametypes/_finalkillcam.gsc', line 646)
    if(!isPlayer(Winner) && !level.doFK[winner])
                            *
Error: called from:
(file 'maps/mp/gametypes/_finalkillcam.gsc', line 560)
        thread startFK( winner );
               *
Error: started from:
(file 'maps/mp/gametypes/_finalkillcam.gsc', line 555)
    wait 9;
    *
Error: **

** script runtime error **
cannot cast undefined to bool: (file 'maps/mp/gametypes/_finalkillcam.gsc', line 646)
    if(!isPlayer(Winner) && !level.doFK[winner])
                         *
Error: called from:
(file 'maps/mp/gametypes/_finalkillcam.gsc', line 560)
        thread startFK( winner );
               *
Error: started from:
(file 'maps/mp/gametypes/_finalkillcam.gsc', line 555)
    wait 9;
    *
Error: **