search

Xezard / XItemsRemover

Simple plugin for Spigot that removes dropped items with a timer displayed on them.
Apache License 2.0
8 stars 4 forks source link

Add AngelChest compatibility, fixes #1 #2

Closed mfnalex closed 3 years ago

mfnalex commented 3 years ago

changed EventPriority to avoid items collected by the AngelChest plugin being tagged with the [pdd] lore, fixes #1

Xezard commented 3 years ago

Dismissed PR because using EventPriority.MONITOR is not recommended. Changed to EventPriority.HIGHEST.

mfnalex commented 3 years ago

Highest will not work. You should use MONITOR since you don't really change the itemstack itself

Xezard commented 3 years ago

Highest will not work. You should use MONITOR since you don't really change the itemstack itself

But I change the lore of the itemstack until the ItemSpawnEvent, where this lore line is removed and the required amount of time is added. EventPriority.MONITOR is not intended for this kind of action and may cause conflicts with other plugins.

mfnalex commented 3 years ago

You change the itemstack, but not the event. Well I don't care, but it will be a 50/50 chance if this will work with AngelChest as AngelChest also listens on HIGHEST. You don't cancel the event or alter it in any way so there is no problem using MONITOR.