Fixing emoji deletion for custom emoji

Xh4H / Discord.jl

The Julia Discord API Wrapper

MIT License

151 stars 24 forks source link

Fixing emoji deletion for custom emoji #26

Closed tobbbles closed 4 years ago

tobbbles commented 4 years ago

What have you changed?

[ ] Added a new feature
[X] Fixed a reported issue (discussed in Discord)
[ ] Updated documentation

Fixing the deletion of custom emoji.

There's a slight issue that users could still mis-use the emoji::StringOrChar method by passing in emoji.name when dealing with custom emoji. I wonder if this should be mentioned in the documentation at all?

christopher-dG commented 4 years ago

Thanks for catching this! On the second point, I think we can leave it.