XhmikosR / notepad2-mod

LOOKING FOR DEVELOPERS - Notepad2-mod, a Notepad2 fork, a fast and light-weight Notepad-like text editor with syntax highlighting
https://xhmikosr.github.io/notepad2-mod/
Other
1.45k stars 270 forks source link

This is a program translation notepad2 To Arabic تعريب برنامج المفكرة2 #217

Open thamermousa opened 6 years ago

thamermousa commented 6 years ago

This is a program translation notepad2 To Arabic تعريب برنامج المفكرة2

مفكرة Notepad2.zip

2018-04-18_074326

But there is no choice Read from right to left

2018-04-18_074458

2018-04-18_074540

zufuliu commented 6 years ago

Right to left is not finished in current Scintilla, https://sourceforge.net/p/scintilla/feature-requests/1214/

Currently Notepad2-mod use 3.7.x long-team version of Scintilla, I think you need to replace Scintilla with a new version after Right to left got finished.

zufuliu commented 6 years ago

Bidirectional is added in Scintilla since 4.1.0 for Direct2D (Vista and above) and macOS Cocoa, see release note on https://www.scintilla.org/. You could contact the developer of the translated program tell she or he to upgrade Scintilla in Notepad2 to 4.1.

Related changes should made in Notepad2's self code include:

  1. Enable Direct2D, just need to build Notepad2 without define DISABLE_D2D, see https://github.com/zufuliu/notepad2/commit/5a9c2a9021e090387459628545d566f7885675d7.
  2. Set rendering technology to DirectWrite, see https://github.com/zufuliu/notepad2/commit/b7ad639fa6e576db2df04ce72e2b69f409f386bd
  3. Set bidirectional to "Left to Right", see https://github.com/zufuliu/notepad2/commit/ef9fe088a1ea578a4ec07dc2aa76eeffafe9f356

It's just a few changes, hope this help you and others.

However there are some issues with Direct2D, which are worth to read: issue https://github.com/XhmikosR/notepad2-mod/issues/121, PR https://github.com/XhmikosR/notepad2-mod/pull/122, and issue https://github.com/rizonesoft/Notepad3/issues/191.

zufuliu commented 6 years ago

For who use GCC, please note a bug report at https://sourceforge.net/p/scintilla/bugs/2026/ about SIGSEGV when bidirectional is enabled.

Also please refer https://sourceforge.net/p/mingw-w64/bugs/753/ or https://github.com/zufuliu/notepad2/issues/16 on how to fix it.