search

XhmikosR / notepad2-mod

LOOKING FOR DEVELOPERS - Notepad2-mod, a Notepad2 fork, a fast and light-weight Notepad-like text editor with syntax highlighting
https://xhmikosr.github.io/notepad2-mod/
Other
1.45k stars 270 forks source link

Added MinGW makefile (works on appveyor). #229

Open dejbug opened 6 years ago

dejbug commented 6 years ago

I was going to add a minor feature (a setting to disable filevars except for explicitly enabled ones, i.e. with "enable-local-variables=1"), to do that I had first to be able to compile the project on my machine (old winxp box). I wanted to do the whole CMake thing, but writing a makefile was for me the quickest approach. I had to rewrite version.sh into a python script (and to make it work on appveyor, I had to fix some of its logic).

This is my first pull request ever. Please bear with me 😸 !

zufuliu commented 6 years ago

Maybe I could use your makefile, see https://github.com/zufuliu/notepad2/issues/2 and https://github.com/zufuliu/notepad2/wiki/Build-Notepad2#gcc

dejbug commented 6 years ago

I see. I'll fix this soon. 👍

dejbug commented 6 years ago

@zufuliu of course! 😄 You should delete the inline overrides (lines 69-77) though. It's rubbish; a carry-over from my initial fiddlings and I just saw that the variables are wrong.

zufuliu commented 6 years ago

@dejbug https://github.com/XhmikosR/notepad2-mod/pull/202 and https://github.com/zufuliu/notepad2/issues/10 and https://github.com/zufuliu/notepad2/commit/547d1c3223bfed7b1114186dfa528d6f579a1ed7 and https://github.com/zufuliu/notepad2/blob/master/src/Edit.c#L3613 might help you to fix GCC build.