search

XhmikosR / notepad2-mod

LOOKING FOR DEVELOPERS - Notepad2-mod, a Notepad2 fork, a fast and light-weight Notepad-like text editor with syntax highlighting
https://xhmikosr.github.io/notepad2-mod/
Other
1.45k stars 270 forks source link

"Fix a few variable reassignments" broke WDK build #89

Closed ghost closed 10 years ago

ghost commented 10 years ago

Running

build_wdk.bat build x64

on master returns this (trimmed)

______________________________
[INFO] Visual Studio 2010 wasn't found, I will use WDK's compiler
______________________________

On branch: master
Hash:      55a39c7
Revision:  922

Styles.c
..\src\Notepad2.c(2874) : error C2143: syntax error : missing ';' before 'type'
..\src\Notepad2.c(2875) : error C2065: 'iNewPos' : undeclared identifier
..\src\Notepad2.c(5080) : error C2061: syntax error : identifier 'MsgNotify'
..\src\Notepad2.c(5080) : error C2059: syntax error : ';'
..\src\Notepad2.c(5080) : error C2059: syntax error : 'type'
NMAKE : fatal error U1077: 'C:\WinDDK\7600.16385.1\bin\x86\amd64\cl.exe' : return code '0x2'
Stop.

______________________________
[ERROR] Compilation failed!
______________________________

Press any key to continue . . .

git bisect reveals this

b2e89111f9201f0205d5b2be13a1efe77f153075 is the first bad commit
commit b2e89111f9201f0205d5b2be13a1efe77f153075
Author: XhmikosR <xhmikosr@users.sourceforge.net>
Date:   Sun Jun 22 11:06:31 2014 +0300
Fix a few variable reassignments.

So b2e8911 is the culprit

XhmikosR commented 10 years ago

I'll probably get rid of WDK support eventually. I have no time or interest to maintain support for old compilers. I use MSVC 2013 only for my projects. On Jun 27, 2014 8:14 PM, "Steven Penny" notifications@github.com wrote:

Running

build_wdk.bat build x64

on master returns this (trimmed)

[INFO] Visual Studio 2010 wasn't found, I will use WDK's compiler

On branch: master Hash: 55a39c7 Revision: 922

Styles.c ..\src\Notepad2.c(2874) : error C2143: syntax error : missing ';' before 'type' ..\src\Notepad2.c(2875) : error C2065: 'iNewPos' : undeclared identifier ..\src\Notepad2.c(5080) : error C2061: syntax error : identifier 'MsgNotify' ..\src\Notepad2.c(5080) : error C2059: syntax error : ';' ..\src\Notepad2.c(5080) : error C2059: syntax error : 'type' NMAKE : fatal error U1077: 'C:\WinDDK\7600.16385.1\bin\x86\amd64\cl.exe' : return code '0x2' Stop.

[ERROR] Compilation failed!

Press any key to continue . . .

git bisect reveals this

b2e89111f9201f0205d5b2be13a1efe77f153075 is the first bad commit commit b2e89111f9201f0205d5b2be13a1efe77f153075 Author: XhmikosR xhmikosr@users.sourceforge.net Date: Sun Jun 22 11:06:31 2014 +0300 Fix a few variable reassignments.

— Reply to this email directly or view it on GitHub https://github.com/XhmikosR/notepad2-mod/issues/89.

ghost commented 10 years ago

Is it possible in theory to compile this with GCC? If so I can look into porting the build script

XhmikosR commented 10 years ago

Not really.