search

XhmikosR / notepad2-mod

LOOKING FOR DEVELOPERS - Notepad2-mod, a Notepad2 fork, a fast and light-weight Notepad-like text editor with syntax highlighting
https://xhmikosr.github.io/notepad2-mod/
Other
1.45k stars 270 forks source link

Use UTF-8 with License file #90

Closed ghost closed 10 years ago

ghost commented 10 years ago

Not doing this create ugly stuff, like this

http://github.com/XhmikosR/notepad2-mod/commit/5bb38ef

XhmikosR commented 10 years ago

Just because GitHub's diff is broken, it doesn't mean we should change something on our side. They should fix their issues.

ghost commented 10 years ago

GitHub’s diff is not broken, this file is. If you look closely you will notice the file is ANSI encoded, yet contains UTF-8 characters.

XhmikosR commented 10 years ago

The file would be broken if it didn't work right when viewing it. It works just fine.

ghost commented 10 years ago

Well, after reviewing Windows-1252, it appears you are correct, sorry about that.

XhmikosR commented 10 years ago

I have already reported to a couple of GitHub guys, let's hope they fix it soon.