XiNiHa / vilay

Vite SSR framework with support for React SSR streaming and Relay
https://vilay.xiniha.dev
MIT License
55 stars 4 forks source link

Allow custom `PageShell`, fix client router issue by passing `pageContext` on navigation #26

Closed acao closed 2 years ago

acao commented 2 years ago

As discussed. I think the hacks in the example I had to add are necessitated to the bug from bundling and singleton module mismatch with render/etc. Doesn't seem that the useContext() result from page context updates client side :/

I think this approach may cause a problem with the context client side? See useEffect/window.location hack for active state.

Todo:

changeset-bot[bot] commented 2 years ago

🦋 Changeset detected

Latest commit: 88152c97937a776b966fd082e217d90bcc36a29b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ----- | ----- | | vilay | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

XiNiHa commented 2 years ago

I've fixed some bugs and tried to improve the overall design, tell me if you have any better ideas! Send me a review request after you're ready with the docs and example stuff :D

acao commented 2 years ago

great, thank you @XiNiHa ! i will finish this PR up then