Xian55 / WowClassicGrindBot

Highly configurable and responsive World of Warcraft Classic pixel Grind Bot - No DLL injection or memory tampering, just screen capture and input simulation.
180 stars 125 forks source link

Known issue: Unable to complete Frame Config at `1280x768` resolution. #416

Closed HeroXx closed 2 years ago

HeroXx commented 2 years ago

Description

I am running 1920x1080 with 100 scaling and cell size 1 and I cannot get past the setup phase.

image

Addon Version

1.7.17

World of Warcraft Client

Wrath of the Lich King Classic

Reproduction Steps

Attempt to run setup on a non VM

Last Good Version

N/A

Screenshots

No response

Logs

No response

Xian55 commented 2 years ago

Hi based on the provided image that dosen't seems to be cell size 1, but much bigger.

I require log message as well in order to proceed further investigation

HeroXx commented 2 years ago

I reset everything with the same result:

image

[22:10:35:408 INF] Found WowProcess
[22:10:35:438 INF] Client window: {X=640,Y=323,Width=1280,Height=768}
[22:10:35:468 INF] Addon installed! Version: 1.7.17
[22:10:35:469 INF] Enter configuration mode.
[22:10:35:973 INF] /fester
[22:10:36:728 INF] Addon installed! Version: 1.7.17
[22:10:36:730 INF] Enter configuration mode.
[22:10:37:239 INF] /fester
[22:10:38:026 INF] DataFrameMeta: hash: 10201100 | spacing: 1 | size: 2 | rows: 1 | frames: 100
[22:10:38:081 INF] Exit configuration mode.
[22:10:38:082 INF] /fester
[22:10:39:664 ERR] Unable to identify ClientVersion UnitRace and UnitClass!
[22:10:39:666 INF] Frame configuration was incomplete! Please try again, after resolving the previusly mentioned issues...
Xian55 commented 2 years ago

Just did a quick test,

Can you try a different resolution such as

HeroXx commented 2 years ago

Same issue on 1024x768:

image

image

Xian55 commented 2 years ago

can you try increase the cell size to 2 at least ?

On the other hand be sure to only one instance of the addon is installed.

Currently your addon name is called fester

Xian55 commented 2 years ago

Are you using any kind of post processing application such as Reshade, which is capable of changing the output pixel color?

On the other hand it is super important to disable glow effect as it affects the UI color.

You can disable the glow by typing in game the /console ffxGlow 0 command, and be sure to properly quit the game. ESC -> Exit Game, in order to save the settings.

HeroXx commented 2 years ago

I only have a single addon of the data grid installed and no I am not using reshade. Cell size 2 made no difference.

image

Does this work on Windows 11?

Xian55 commented 2 years ago

Are you using any kind of Image Sharpening application, such as in the AMD radeon driver or in Nvidia control panel?

HeroXx commented 2 years ago

No, I followed the guide and checked Nvidia Control panel for those settings.

Xian55 commented 2 years ago

Does this work on Windows 11?

Personally i have not tested, nor i can validate.

Xian55 commented 2 years ago

May i ask you to try out in full screen mode?

Xian55 commented 2 years ago

Blizzard just posted a new patch, and the addon yields lua errors.

You can enable to show lua errors by /console scriptErrors 1

For me it shows

image

If you wish to disable it type /console scriptErrors 0

HeroXx commented 2 years ago

Yes I also get a large amount of errors, I assumed it was just something everyone got

Xian55 commented 2 years ago

Give me a few minutes, fix is on the way!

HeroXx commented 2 years ago

image

HeroXx commented 2 years ago

Changing versions.lua to:

if WOW_PROJECT_ID == WOW_PROJECT_MAINLINE then
    DataToColor.ClientVersion = 1
elseif WOW_PROJECT_ID == WOW_PROJECT_BURNING_CRUSADE_CLASSIC or WOW_PROJECT_ID == WOW_PROJECT_WRATH_CLASSIC then
    if LE_EXPANSION_LEVEL_CURRENT == LE_EXPANSION_NORTHREND or LE_EXPANSION_LEVEL_CURRENT == LE_EXPANSION_WRATH_OF_THE_LICH_KING then
        DataToColor.ClientVersion = 4
    elseif LE_EXPANSION_LEVEL_CURRENT == LE_EXPANSION_BURNING_CRUSADE then
        DataToColor.ClientVersion = 3
    end
elseif WOW_PROJECT_ID == WOW_PROJECT_CLASSIC then
    DataToColor.ClientVersion = 2
end

Fixed that issue for me, but now I have: image

Xian55 commented 2 years ago

https://github.com/Xian55/WowClassicGrindBot/pull/417 is up the lua errors should gone.

However the 1280x768 resolution still not working, my initial guess is scaling issue.

May i recommend to try out 1024x768 or 1280x960 resolutions ?

Let me know your results!

HeroXx commented 2 years ago

Thank you, it appears to be working on 1920x1080. My final question, should the mage profile lvl 1 always try to approach the mob? it just approaches and cancels the cast constantly.

Xian55 commented 2 years ago

It was a long time since i spent time on level 1 profiles.

Many sub system has been changed since, it is possible i broke compatibility, sadly.

Xian55 commented 2 years ago

You can try this construct

  "Pull": {
    "Sequence": [
      {
        "Name": "Fireball",
        "Key": "2",
        "HasCastBar": true,
        "Requirement": "Mana% > MIN_MANA_FIREBALL%",
        "AfterCastWaitCastbar": true
      },
      {
        "Name": "Approach",
        "Log": false
      }
    ]
  },
Xian55 commented 2 years ago

I updated the docs about Casting Handler

HeroXx commented 2 years ago

Thank you. That seems to make it better but it does seem to interrupt itself quite a bit:

... AfterCastWaitCastbar(h) 1092ms or interrupt...
Xian55 commented 2 years ago

Going to look at it later, thanks for the report!

Blizz might changed something with the latest patch.

Like adding this WOW_PROJECT_WRATH_CLASSIC seems really lame, especially the prepatch is out from couple of days.

Xian55 commented 2 years ago

oh i see there are more lua errors :(

Xian55 commented 2 years ago

https://github.com/Xian55/WowClassicGrindBot/pull/418 should fix casting problems!