search

Xian55 / WowClassicGrindBot

Highly configurable and responsive World of Warcraft Classic pixel Grind Bot - No DLL injection or memory tampering, just screen capture and input simulation.
190 stars 127 forks source link

Not looting after kill #491

Closed Phatlynx closed 1 year ago

Phatlynx commented 1 year ago

Description

After a kill, the corpse is not consumed.

Addon Version

Current Version

World of Warcraft Client

Wrath of the Lich King Classic

Reproduction Steps

N/A

Last Good Version

N/A

Screenshots

druid class config

{
  "ClassName": "Druid",
  "Loot": true,
  "PathFilename": "_pack\\60-70\\Nagrand\\65-70 Oshugun.json",
  "PathReduceSteps": true,
  "PathThereAndBack": false,
  "NPCMaxLevels_Below": 5,
  "NPCMaxLevels_Above": 4,
  "CheckTargetGivesExp": true,
  "Blacklist": [
    "Fel Reaver",
    "Banthar"
  ],
  "IntVariables": {
    "MIN_TARGET_HP_DOT%": 20,
    "Debuff_Mangle": 132135
  },
  "Form": [
    {
      "Name": "cancelform",
      "Key": "F11",
      "Form": "None"
    },
    {
      "Name": "Bear Form",
      "Key": "-",
      "Form": "Druid_Bear"
    },
    {
      "Name": "Cat form",
      "Key": "=",
      "Form": "Druid_Cat"
    },
    {
      "Name": "Travel form",
      "Key": "0",
      "Form": "Druid_Travel"
    }
  ],
  "Pull": {
    "Sequence": [
      {
        "Name": "Cat Form",
        "Key": "=",
        "Requirements": [
          "SpellInRange:0",
          "!Form:Druid_Cat"
        ]
      },
      {
        "Name": "Faerie Fire (Feral)",
        "Key": "F10",
        "AfterCastAuraExpected": true,
        "Requirements": [
          "Form:Druid_Cat || Form:Druid_Bear",
          "!Faerie Fire"
        ]
      }
    ]
  },
  "Combat": {
    "Sequence": [
      {
        "Name": "Regrowth",
        "Key": "8",
        "HasCastBar": true,
        "WhenUsable": true,
        "AfterCastAuraExpected": true,
        "AfterCastWaitCastbar": true,
        "Requirements": [
          "Health% < 51",
          "Mana% > 31",
          "!Regrowth"
        ],
        "Form": "None"
      },
      {
        "Name": "Rejuvenation",
        "Key": "7",
        "Form": "None",
        "BeforeCastStop": true,
        "AfterCastWaitBuff": true,
        "Requirements": [
          "Health% < 40",
          "Mana% > 31",
          "!Rejuvenation"
        ]
      },
      {
        "Name": "Healing Touch",
        "Key": "5",
        "HasCastBar": true,
        "WhenUsable": true,
        "AfterCastAuraExpected": true,
        "AfterCastWaitCastbar": true,
        "Requirements": [
          "Health% < 35",
          "Mana% > 31"
        ],
        "Form": "None"
      },
      {
        "Name": "Tiger's Fury",
        "Key": "N8",
        "WhenUsable": true,
        "Requirements": [
          "Form:Druid_Cat",
          "!TigersFury",
          "Rip",
          "Rake",
          "InMeleeRange",
          "TargetHealth% > MIN_TARGET_HP_DOT%"
        ],
        "Form": "Druid_Cat"
      },
      {
        "Name": "Mangle",
        "Key": "2",
        "WhenUsable": true,
        "AfterCastAuraExpected": true,
        "Requirements": [
          "SpellInRange:2",
          "MobCount < 2",
          "Form:Druid_Cat"
        ],
        "Form": "Druid_Cat",
        "Cooldown": 3000
      },
      {
        "Name": "Rip",
        "Key": "N6",
        "WhenUsable": true,
        "Requirements": [
          "MobCount < 2",
          "SpellInRange:2",
          "!Rip",
          "Combo Point > 0",
          "Form:Druid_Cat",
          "TargetHealth% > MIN_TARGET_HP_DOT%"
        ],
        "Form": "Druid_Cat"
      },
      {
        "Name": "Rake",
        "Key": "N7",
        "WhenUsable": true,
        "Requirements": [
          "SpellInRange:2",
          "!Rake",
          "MobCount < 2",
          "Form:Druid_Cat",
          "TargetHealth% > MIN_TARGET_HP_DOT%"
        ],
        "Form": "Druid_Cat"
      },
      {
        "Name": "Ferocious Bite",
        "Key": "N3",
        "WhenUsable": true,
        "Requirements": [
          "SpellInRange:2",
          "MobCount < 2",
          "Form:Druid_Cat",
          "TargetHealth% <= MIN_TARGET_HP_DOT%"
        ],
        "Form": "Druid_Cat"
      },
      {
        "Name": "Bear Form",
        "Key": "-",
        "Requirements": [
          "!Form:Druid_Bear",
          "MobCount > 1",
          "Mana% > 30"
        ]
      },
      {
        "Name": "Bash",
        "Key": "F8",
        "WhenUsable": true,
        "AfterCastWaitGCD": true,
        "Requirements": [
          "SpellInRange:1",
          "(TargetCastingSpell && !TargetCastingSpell:3131 && !TargetCastingSpell:3443 && !TargetCastingSpell:6917) || Health% < 33",
          "!Form:Druid_Cat"
        ],
        "Form": "Druid_Bear",
        "AferCastWaitGCD": true
      },
      {
        "Name": "Enrage",
        "Key": "F6",
        "WhenUsable": true,
        "Requirement": "Form:Druid_Bear",
        "Form": "Druid_Bear"
      },
      {
        "Name": "Demoralizing Roar",
        "Key": "F5",
        "WhenUsable": true,
        "Requirements": [
          "InMeleeRange",
          "!Demoralizing Roar",
          "MobCount > 1",
          "Form:Druid_Bear"
        ],
        "Form": "Druid_Bear"
      },
      {
        "Name": "Swipe",
        "Key": "F4",
        "WhenUsable": true,
        "Requirements": [
          "InMeleeRange",
          "MobCount > 1",
          "Form:Druid_Bear"
        ],
        "Form": "Druid_Bear"
      },
      {
        "Name": "Maul",
        "Key": "F3",
        "Requirements": [
          "InMeleeRange",
          "MobCount < 3",
          "LastMainHandMs > 2100",
          "Form:Druid_Bear"
        ],
        "AfterCastWaitSwing": true,
        "Form": "Druid_Bear"
      },
      {
        "Name": "Cat Form",
        "Key": "=",
        "Requirements": [
          "!Form:Druid_Cat",
          "MobCount < 2"
        ]
      },
      {
        "Name": "Faerie Fire (Feral)",
        "Key": "F10",
        "Usable": true,
        "AfterCastAuraExpected": true,
        "Requirements": [
          "Form:Druid_Cat || Form:Druid_Bear",
          "!Faerie Fire"
        ]
      },
      {
        "Name": "AutoAttack",
        "Requirements": [
          "!AutoAttacking"
        ]
      },
      {
        "Name": "Approach",
        "Log": false
      }
    ]
  },
  "Adhoc": {
    "Sequence": [
      {
        "Name": "Mark of the Wild",
        "Key": "1",
        "Requirement": "!Mark of the Wild",
        "Form": "None"
      },
      {
        "Name": "Thorns",
        "Key": "9",
        "Requirement": "!Thorns",
        "Form": "None"
      },
      {
        "Name": "Regrowth",
        "Key": "8",
        "Form": "None",
        "HasCastBar": true,
        "WhenUsable": true,
        "AfterCastWaitBuff": true,
        "Requirements": [
          "Health% < 65",
          "!Regrowth"
        ]
      },
      {
        "Name": "Rejuvenation",
        "Key": "7",
        "BeforeCastStop": true,
        "AfterCastWaitBuff": true,
        "Requirements": [
          "Health% < 75",
          "!Rejuvenation"
        ],
        "Form": "None"
      },
      {
        "Name": "Innervate",
        "Key": "6",
        "Requirement": "Mana% < 21",
        "Cooldown": 180000
      }
    ]
  },
  "Parallel": {
    "Sequence": [
      {
        "Name": "Food",
        "Key": "2",
        "Requirement": "Health% < 2",
        "Form": "None"
      },
      {
        "Name": "Drink",
        "Key": "3",
        "Requirement": "Mana% < 2",
        "Form": "None"
      }
    ]
  },
  "Wait": {
    "Sequence": [
      {
        "Cost": 19,
        "Name": "Mana regen",
        "Requirements": [
          "DrinkCount == 0 || !Usable:Drink",
          "Mana%<15"
        ]
      }
    ]
  }
}

Logs

out20230125_001.log

Xian55 commented 1 year ago

Hey 👋

Based on the log have some issue finding the corpse names on the screen

[23:42:31:855 INF] Kill credit detected! Known kills: 2 | Fighting with: 0
[23:42:31:856 INF] New Plan=  Consume Corpse
[23:42:31:858 INF] ----- Safe to consume a corpse.
[23:42:31:871 INF] New Plan=  Loot
[23:42:31:873 INF] [NpcNameFinder] type = Corpse
[23:42:31:918 INF] Look at possible closest corpse and try once again...
[23:42:32:224 INF] LootGoal: Loot Failed, target not found!
[23:42:32:239 INF] New Plan=  Corpse Consumed
[23:42:32:241 INF] ----- Corpse consumed. Total: 2 | Remaining: 1
[23:42:32:562 INF] New Plan=  Consume Corpse
[23:42:32:564 INF] ----- Safe to consume a corpse.
[23:42:32:577 INF] New Plan=  Loot
[23:42:33:163 INF] Look at possible closest corpse and try once again...
[23:42:33:287 INF] LootGoal: Loot Failed, target not found!
[23:42:33:302 INF] New Plan=  Corpse Consumed
[23:42:33:304 INF] ----- Corpse consumed. Total: 0 | Remaining: 0
[23:42:33:318 WRN] New Plan= NO PLAN

Be sure that the glow effect is disabled via /console ffxGlow 0 and when you exit the game do not use ALT+F4 rather exit the game properly. ESC > Exit Game

Not so long ago made some changes regarding how the ScreenshotThread sync's with the BotThread, i might broke the timings let me have a look!

Xian55 commented 1 year ago

On the dev branch i just increased the buffers by 2 times. https://github.com/Xian55/WowClassicGrindBot/commit/fe5ecb74822836d19806666c3ef61556eec0be22

Please take a look.

Xian55 commented 1 year ago

Hey have you still experiencing the issue, did you have time to checkout the latest changes ?

Phatlynx commented 1 year ago

Hello! Everything works fine now. Sorry for not closing this earlier.