Xian55 / WowClassicGrindBot

Highly configurable and responsive World of Warcraft Classic pixel Grind Bot - No DLL injection or memory tampering, just screen capture and input simulation.
161 stars 117 forks source link

[Sod] Add Auras - Hunter - "Aspect of the Lion" is now "Heart of the Lion" #559

Open augerT opened 6 months ago

augerT commented 6 months ago

Description

Aspect of the Lion is now Heart of the Lion.

Tried updating the Spell ID name but I still get "UNKNOWN REQUIREMENT" from blazor server...

Addon Version

1.7.50

World of Warcraft Client

Season of Mastery

Reproduction Steps

  1. Add Heart of the Lion as a requirement to an action
  2. Start server
  3. "UNKOWN REQUIREMENT! Heart of the Lion"

Last Good Version

No response

Screenshots

image

Logs

No response

Xian55 commented 6 months ago

Hello there, i have not yet added any kind of Season of Mastery based spells to the requirements.

In the past few weeks i've played a little bit of hunter, to my knowledge around 13th of December, they changed how the formerly known Aspect of the Lion worked, previously it was an active Aura, then later on they changed to a Passive Aura. So you can have another spell active such as Aspect of the hawk.

I'm not completely sure how i should handle the Season of Mastery spells among requirements. Blizzard is probably going to keep adding more spells, or radically change a few. My goal is to keep the backward compatibility with the vanilla client as much as possible. On the other hand, some of the classes like Paladins probably going to have more then 24 buff to track.

Currently what i can recommend, is to use the Player buff timer Note that, you have to use the spell texture Id, what you can lookup in wowhead, this is a less reliable way to this, as the player buff timers, not extracted in a single frame, but spread around in time. So you may add a "Cooldown": 5000 or something like that to the KeyAction definition, to avoid infinitely toggling on and off the spell.

image

augerT commented 6 months ago

Thanks for the reply. I have another work around for heart of the lion but I'll keep this in mind for future sod spells.

Xian55 commented 6 months ago

I've updated the dbc data with the latest 1.15.0.52610 patch since https://github.com/Xian55/WowClassicGrindBot/commit/ae3422088bc018d3c02f0bd7b0b08dd3d2343f04

Sadly none of the PTR servers are online, i'm going to test it, once any of the servers come back online.