DK doesn't attack with abilities due most of the Rank 1 spells have been removed since Cataclysm

starnodes commented 1 month ago

Description

Hello! I play official Cataclysm Classic Version: 4.4.0.54737 I downloaded the latest version of the addon and it seems a lot has changed :) I have 2 problems: 1) I tried to run the bot in AttendedGrind mode, but my dk just runs up to the target and hits him with a basic attack, then collects the skin. 2) Also, custom button changes stopped working for me. "TargetLastTargetKey": "F9", "InteractMouseOverKey": "F8", "InteractKey": "F7", "TargetTargetOfTargetKey": "F6", "TargetPetKey": "F12", "PetAttackKey": "F11", "TargetFocusKey": "F10", Although I tried in different ways to change the configuration in accordance with the documentation update, nothing worked for me :) The bot simply pressed "I" instead of "F7". I temporarily changed the settings in the game to test the work further.

My full config:

{ "ClassName": "DeatkKnight", "TargetLastTargetKey": "F9", "InteractMouseOverKey": "F8", "InteractKey": "F7", "TargetTargetOfTargetKey": "F6", "TargetPetKey": "F12", "PetAttackKey": "F11", "TargetFocusKey": "F10", "MountKey": "-", "NPCMaxLevels_Below": 99, "NPCMaxLevels_Above": 99, // "Mode": "Grind", // "Mode": "AssistFocus", "Mode": "AttendedGrind", "Loot": true, "Skin": true, "KeyboardOnly": true, "PathFilename": "_pack\70-80\Zul'Drak\76-80_Zul'Drak_Heb'Valok_spiders.json", "PathThereAndBack": false, "PathReduceSteps": true, "IntVariables": { "MIN_HP_FOOD%": 40, "MIN_RUNE_TO_DUMP": 40, "ITEM_CORPSE_DUST": 37201, "Debuff_Frost Fever": 237522, "Debuff_Blood Plague": 237514, "MIN_TIME_REFRESH": 3500 },

"Pull": { "Sequence": [ { "Name": "Icy Touch", "Key": "5", "WhenUsable": true, "Requirements": [ "!TargetCastingSpell", "!Frost Fever", "SpellInRange:0" ], "AfterCastAuraExpected": true, "AfterCastWaitCombat": true }, { "Name": "Death Grip", "Key": "F1", "WhenUsable": true, "Requirements": [ "SpellInRange:2", "!Falling" ], "AfterCastWaitCombat": true, "AfterCastWaitMeleeRange": true } ] },

"Combat": { "Sequence": [ { "Name": "Заморозка разума", "Key": "R", "WhenUsable": true, "Requirements": [ "InMeleeRange", "TargetCastingSpell" ] },

  {
    "Name": "Death Strike",
    "Key": "3",
    "WhenUsable": true,
    "Requirements": [
      "InMeleeRange"
    ]
  },
  {
    "Name": "dnd", // macro /cast [@player] Death and Decay
    "Key": "V",
    "WhenUsable": true,
    "Requirements": [
      "MobCount > 2",
      "InMeleeRange"
    ]
  },

  {
    "Name": "Icy Touch",
    "Key": "5",
    "WhenUsable": true,
    "Requirements": [
      "!Frost Fever",
      "SpellInRange:0"
    ],
    "AfterCastAuraExpected": true
  },
  {
    "Name": "Удар в сердце",
    "Key": "4",
    "WhenUsable": true,
    "Cooldown": 2000,
    "Requirements": [
      "MobCount < 2",
      "Frost Fever",
      "Blood Plague",
      "InMeleeRange"
    ]
  },
  {
    "Name": "Pestilence",
    "Key": "E",
    "WhenUsable": true,
    "Requirements": [
      "MobCount > 2",
      "TargetHealth% <= 50 && (Frost Fever || Blood Plague)",
      "InMeleeRange"
    ]
  },
  {
    "Name": "Рунический удар",
    "Key": "2",
    "WhenUsable": true,
    "Requirements": [
      "RunicPower >= 60",
      "SpellInRange:1"
    ]
  },
  {
    "Name": "Plague Strike",
    "Key": "1",
    "WhenUsable": true,
    "Requirements": [
      "!Blood Plague",
      "InMeleeRange"
    ],
    "AfterCastAuraExpected": true
  },

  {
    "Name": "AutoAttack",
    "Requirements": [
      "!AutoAttacking"
    ]
  },
  {
    "Name": "Approach",
    "Log": false
  }
]

}, "Adhoc": { "Sequence": [ { "Name": "Зимний горн", "Key": "7", "Cooldown": 60000, "Requirements": [ "!Mounted" ] },

  {
    "Name": "Food",
    "Key": "=",
    "Requirement": "Health% < MIN_HP_FOOD%"
  }
]

}, }

Addon Version

1.7.57

World of Warcraft Client

Wrath of the Lich King Classic

Reproduction Steps

Description

Last Good Version

No response

Screenshots

No response

Logs

Xian55 commented 1 month ago

Hello, could you upload the log files ?

Just drag and drop into the comment.

it can be found next to the executable.

Please dont do any post processing of the logs.

I will look into it tomorrow. Thanks for bringing it to my attention.

Have a good day!

Xian55 commented 1 month ago

"TargetLastTargetKey": "F9", "InteractMouseOverKey": "F8", "InteractKey": "F7",

These wont work anymore. They are consolidated.

I would recommend to try this #553

If you experience something which does not work, i recommend to use the following serach keyword under the pull requests.

https://github.com/Xian55/WowClassicGrindBot/pulls?q=is%3Apr+is%3Aclosed+breaking+change

Every breaking changes what i made should be noted there.

starnodes commented 1 month ago

out20240529_002.log

I first tried to use this format in the character configuration, but the bot stubbornly used the standard setting. "Mount": { "Key": "N0" }

Xian55 commented 1 month ago

Ye based on the logs the key mapping is wrong.

I will look into it tomorrow.

starnodes commented 1 month ago

Ye based on the logs the key mapping is wrong.

I will look into it tomorrow.

This is a really old key setting. I propose to start the investigation with the problem due to which my dk does not use abilities. And tomorrow I will upload a log with the key configuration from your recommendation. Thank you!

Xian55 commented 1 month ago

[dnd] Unable to assign Actionbar Slot! [02:58:36:797 I] [dnd ] Non Actionbar V -> V [02:58:36:798 W] [Pestilence] Unable to assign Actionbar Slot! [02:58:36:798 I] [Pestilence ] Non Actionbar E -> E

These wont work. Based on the rules probably stuck at trying to use a key which is not bound to the acrionbar.

Currently the actionbar is fixed. Customization is not supported for actionbar.

Please look at the valid actionbar keys https://github.com/Xian55/WowClassicGrindBot/blob/9216f25a75e873705b70b2f826363358f3ed33da/Core/ClassConfig/KeyReader.cs#L17

Either you add those E and V keys into the dictionaries.

Or you setup secondary keybinds in game for the actionbar slots.

When you setup the class config be sure to use valid ([F/N])0-9 keys.

Without these mapping the program will not know which actionbar slot to look for the usable and cost info. So its never going to use the given "E" and "V" mentioned spells.

starnodes commented 1 month ago

[dnd] Unable to assign Actionbar Slot! [02:58:36:797 I] [dnd ] Non Actionbar V -> V [02:58:36:798 W] [Pestilence] Unable to assign Actionbar Slot! [02:58:36:798 I] [Pestilence ] Non Actionbar E -> E

These wont work. Based on the rules probably stuck at trying to use a key which is not bound to the acrionbar.

Currently the actionbar is fixed. Customization is not supported for actionbar.

Please look at the valid actionbar keys

https://github.com/Xian55/WowClassicGrindBot/blob/9216f25a75e873705b70b2f826363358f3ed33da/Core/ClassConfig/KeyReader.cs#L17

Either you add those E and V keys into the dictionaries.

Or you setup secondary keybinds in game for the actionbar slots.

When you setup the class config be sure to use valid ([F/N])0-9 keys.

Without these mapping the program will not know which actionbar slot to look for the usable and cost info. So its never going to use the given "E" and "V" mentioned spells.

I reassigned the keys, but my DK still attacks without abilities.

DKNEW.json

out20240529.log

Xian55 commented 1 month ago

It seems the bot unable to enter the CombatGoal, it stuck at the ApproachTarget

[14:03:56:161 I] [GoapAgent ] New Plan= Approach Target

To enter CombatGoal specific conditions needs to met.

AddPrecondition(GoapKey.incombat, true); AddPrecondition(GoapKey.hastarget, true); AddPrecondition(GoapKey.targetisalive, true); AddPrecondition(GoapKey.targethostile, true); AddPrecondition(GoapKey.incombatrange, true);

It might be that blizzard introduced some breaking changes regarding to these conditions, i will look at it later today.

Xian55 commented 1 month ago

I can see the problem now, the spell ranges are not working at all.

During WOTLK the Icy Touch (Rank 1) spell id was 49903 which is no longer used in the Cataclysm client.

I will try to resolve this issue by using a different way to identify the spells no mater the game client version. Basically using the spell icons over the ids and looking up the spells from the spell book at startup.

Xian55 commented 1 month ago

Spell ranges should be fixed, be sure to use the [Addon: 1.7.59] version. Get the latest dev branch and follow this guide.

For me changing the Mount works fine.

Overriding it the following way works.

"Mount": { "Key": "N0"},

So the rest of the BaseAction keys should behave the same way. The BaseAction keys can be found here.

Let me know if you have further issue regarding to this.

TODO: remind myself to fix Druid Wrath Spell Icon ID, as its been changed from Wrath to Cata...

starnodes commented 1 month ago

Hello! )) My bot often writes "[I] press random" and is bad at skinning animals. What could go wrong? out20240530_006.log

Xian55 commented 1 month ago

Hey,

bad at skinning animals

Based on the logs i can see

Loot Failed

3x times.

Loot Successful

50x times.

So i'm not sure how to interpret this. A little bit more context would be helpful.

My bot often writes "[I] press random"

That means it presses the [i] / interact button where the "press random" means that the keydown press duration is a random interval, you don't have to bother with that, that's just part of the implementation. There are a few places where exact keypress duration is used, like the character turning left right. The rest of the key presses are random in order to avoid using constant key presses.

Are you using custom keybinds ?

Without more context its ambiguous for me if that's a problem or not even with the provided logs i'm not sure what i'm supposed to look at.

Gooday

starnodes commented 1 month ago

Hey,

bad at skinning animals

Based on the logs i can see

Loot Failed

3x times.

Loot Successful

50x times.

So i'm not sure how to interpret this. A little bit more context would be helpful.

My bot often writes "[I] press random"

That means it presses the [i] / interact button where the "press random" means that the keydown press duration is a random interval, you don't have to bother with that, that's just part of the implementation. There are a few places where exact keypress duration is used, like the character turning left right. The rest of the key presses are random in order to avoid using constant key presses.

Are you using custom keybinds ?

Without more context its ambiguous for me if that's a problem or not even with the provided logs i'm not sure what i'm supposed to look at.

Gooday

Thank you for your answer, I’ll keep watching for longer and report back with the results. At the moment I have only used numbers 1-9.0 for the key

starnodes commented 1 month ago

I also have a problem that I can’t get the bot to work on the 2nd monitor. My main monitor is 3440 x 1440 and my second monitor is 1920 x 1080. Before updating the bot (Version: 3.4.3.52237 Addon version: 1.7.47) it worked, but now it also stopped (Version: 4.4.0.54901 Addon version: 1.7.59)

Xian55 commented 1 month ago

My main monitor is 3440 x 1440 and my second monitor is 1920 x 1080.

I actually have the exact same setup. For me its working fine, i did some fixes a couple of months about it. So i would require more info about you use case.

However this issue has not related to #589 so open about a new issue please.

Xian55 / WowClassicGrindBot