XiangRongLin / NewPipe-preuinified

NewPipe with the old UI. Looking for new Maintainer
GNU General Public License v3.0
53 stars 6 forks source link

Making it compatible with OUYA #11

Closed ZacharyFoxx closed 2 years ago

ZacharyFoxx commented 2 years ago

These changes only make that when installed in OUYA, the application appears in the PLAY menu of OUYA, with an icon in the pattern expected by OUYA.

Looking at the retroarch and spmc (Kodi fork) projects:

SPMC:

In the project github, searching for OUYA, you can see that the code has been removed from version 15, because it is not Compatible with Android below 4.2 (OUYA use android 4.1.1 JellyBeam).

You can check the latest OUYA-compatible version, version 14.2, and you will find which the code in AndroidManifest.xml and the icon are there.

RETROARCH:

By searching for OUYA, you will find which RETROARCH's AndroidManifest.xml has the line about OUYA:

As NewPipe is not a game, the entry in his AndroidManifest.xml is the same as in SPMC:

OUYA SDK:

You can find more examples on the OUYA github (It is abandoned with the end of OUYA support).

When installing an app on OUYA using its DISCOVER store, the app should appear within the PLAY menu.

XiangRongLin commented 2 years ago

Seeing how niche this is I would not add it. Additionally NewPipe is minSDK 19 see here, which translates to Android 4.4 https://developer.android.com/studio/releases/platforms. This is above what you described OUYA to work with

because it is not Compatible with Android below 4.2 (OUYA use android 4.1.1 JellyBeam)


You can easily build this yourself. I setup a release pipeline (https://github.com/XiangRongLin/NewPipe-preuinified/blob/pre-unified/.github/workflows/release.yml) for myself where you just need to provide signing information (see the action)

kubo6472 commented 2 years ago

Hey @ZacharyFoxx let me introduce you to futureproofing: 1. Don't expect that your bodged treating of icons or what is to be fixed in "upstream". If it ain't broken, don't fix it. The app has no issues for normal users, you need to fix stuff on your end. Example from the world of minecraft: https://github.com/EssentialsX/Essentials/pull/3580