search

XiangRongLin / NewPipe-preuinified

NewPipe with the old UI. Looking for new Maintainer
GNU General Public License v3.0
53 stars 6 forks source link

Crashing on not being able to get like counts #31

Closed kubo6472 closed 1 year ago

kubo6472 commented 1 year ago

Version

Steps to reproduce the bug

  1. Play any video with hidden like counts

Expected behavior

The video would play okay

Actual behaviour

Audio works fine, but opening a video or a popup fails with unable to play.

Screenshots/Screen recordings

Logs

Exception

Crash log

``` org.schabi.newpipe.extractor.exceptions.ParsingException: Could not get like count at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getLikeCount(YoutubeStreamExtractor.java:452) at org.schabi.newpipe.extractor.stream.StreamInfo.extractOptionalData(StreamInfo.java:279) at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:83) at org.schabi.newpipe.extractor.stream.StreamInfo.getInfo(StreamInfo.java:73) at org.schabi.newpipe.util.ExtractorHelper.lambda$getStreamInfo$3(ExtractorHelper.java:117) at org.schabi.newpipe.util.-$$Lambda$ExtractorHelper$YTHJjScxCJNO1LTCqs3IKy35iyY.call(Unknown Source:4) at io.reactivex.internal.operators.single.SingleFromCallable.subscribeActual(SingleFromCallable.java:44) at io.reactivex.Single.subscribe(Single.java:3666) at io.reactivex.internal.operators.single.SingleDoOnSuccess.subscribeActual(SingleDoOnSuccess.java:35) at io.reactivex.Single.subscribe(Single.java:3666) at io.reactivex.internal.operators.maybe.MaybeFromSingle.subscribeActual(MaybeFromSingle.java:41) at io.reactivex.Maybe.subscribe(Maybe.java:4290) at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.drain(MaybeConcatArray.java:153) at io.reactivex.internal.operators.maybe.MaybeConcatArray$ConcatMaybeObserver.request(MaybeConcatArray.java:78) at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe$ElementAtSubscriber.onSubscribe(FlowableElementAtMaybe.java:66) at io.reactivex.internal.operators.maybe.MaybeConcatArray.subscribeActual(MaybeConcatArray.java:42) at io.reactivex.Flowable.subscribe(Flowable.java:14935) at io.reactivex.internal.operators.flowable.FlowableElementAtMaybe.subscribeActual(FlowableElementAtMaybe.java:36) at io.reactivex.Maybe.subscribe(Maybe.java:4290) at io.reactivex.internal.operators.maybe.MaybeToSingle.subscribeActual(MaybeToSingle.java:46) at io.reactivex.Single.subscribe(Single.java:3666) at io.reactivex.internal.operators.single.SingleObserveOn.subscribeActual(SingleObserveOn.java:35) at io.reactivex.Single.subscribe(Single.java:3666) at io.reactivex.Single.subscribe(Single.java:3652) at org.schabi.newpipe.RouterActivity$FetcherService.handleChoice(RouterActivity.java:666) at org.schabi.newpipe.RouterActivity$FetcherService.onHandleIntent(RouterActivity.java:638) at android.app.IntentService$ServiceHandler.handleMessage(IntentService.java:77) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loop(Looper.java:246) at android.os.HandlerThread.run(HandlerThread.java:67) Caused by: org.schabi.newpipe.extractor.exceptions.ParsingException: Ratings are enabled even though the like button is missing at org.schabi.newpipe.extractor.services.youtube.extractors.YoutubeStreamExtractor.getLikeCount(YoutubeStreamExtractor.java:436) ... 29 more ```

P.S. I'm just posting this to inform you/everyone. I know you don't have the time to work on this, so perhaps I, or more likely someone a tad more experienced might take the wheel on this one.

kubo6472 commented 1 year ago

TeamNewPipe/NewPipeExtractor#926 is possibly related.

kubo6472 commented 1 year ago

Okay, these are two different things. This bump in #32 helps get rid of the like count error, but it still doesn't help with "could not play this stream"

RSoulwin commented 1 year ago

@kubo6472 , can you try with latest? Release: https://github.com/XiangRongLin/NewPipe-preuinified/releases/tag/v0.22.3.2

It should be fixed with updated Extractor now.